[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/2] qemu-iotests: Add dependency to qemu-nbd
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/2] qemu-iotests: Add dependency to qemu-nbd tool |
Date: |
Thu, 7 Mar 2019 10:17:39 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 3/7/19 9:10 AM, Philippe Mathieu-Daudé wrote:
> Since a9660664fde, some iotests use qemu-nbd.
> Add a dependency to build it before using it.
> This fixes:
>
> $ make check-block
> GEN qemu-img-cmds.h
> CC qemu-img.o
> LINK qemu-img
> CC qemu-io.o
> LINK qemu-io
> CC tests/qemu-iotests/socket_scm_helper.o
> LINK tests/qemu-iotests/socket_scm_helper
> tests/qemu-iotests-quick.sh
> check: qemu-nbd not found
> make: *** [tests/Makefile.include:1059: check-tests/qemu-iotests-quick.sh]
> Error 1
>
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I still have an NBD pull request coming up before soft freeze. Should I
be planning to take this patch (as it is NBD-related) or the whole
series (even though the first is more of a stretch), or is there a
better tree for this to be staged through?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature