Re: [Qemu-devel] [PATCH v2 4/5] iothread: push gcontext earlier in the thread_fn

[Stefan Hajnoczi]

On Wed, Mar 06, 2019 at 07:55:31PM +0800, Peter Xu wrote:
> +    /*
> +     * We should do this as soon as we enter the thread, because the
> +     * function will silently fail if it fails to acquire the
> +     * gcontext.
> +     */
> +    g_main_context_push_thread_default(iothread->worker_context);

I have a hard time understanding this comment.  The mention of how it
fails makes me think "we'll never find out about failures anyway, so how
does it help to call this early?".

I suggest sticking to the point that this function must always be called
first:

  /*
   * g_main_context_push_thread_default() must be called before anything
   * in this new thread uses glib.
   */

Now people will think before moving this function call.

Stefan

signature.asc
Description: PGP signature