Re: [Qemu-devel] [PATCH v2 09/11] Makefile, configure: Support building rST documentation

[Paolo Bonzini]

On 05/03/19 16:24, Peter Maydell wrote:
> On Tue, 5 Mar 2019 at 12:47, Peter Maydell <address@hidden> wrote:
>>
>> On Thu, 28 Feb 2019 at 15:49, Philippe Mathieu-Daudé <address@hidden> wrote:
>>>
>>> Hi Peter,
>>>
>>> On 2/28/19 3:56 PM, Peter Maydell wrote:
>>>> +# Sphinx builds all its documentation at once in one invocation
>>>> +# and handles "don't rebuild things unless necessary" itself.
>>>> +# The '.doctrees' files are cached information to speed this up.
>>>
>>> Can you add .doctrees to .gitignore?
>>
>> Since this was the only change request for this patchset,
>> I plan to send out a pullreq containing it, with this folded
>> into this patch:
>>
>> diff --git a/.gitignore b/.gitignore
>> index b66b7725512..77522561b8e 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -1,3 +1,4 @@
>> +/.doctrees
>>  /config-devices.*
>>  /config-all-devices.*
>>  /config-all-disas.*
> 
> Testing on various hosts revealed that we have a problem on
> hosts with ancient versions of sphinx that predate the 'alabaster'
> theme, so the configure test needs to be smarter. The fixup is
> the change below.
> 
> Are people OK with me squashing this in too, or have we
> reached the point where it really ought to have a v3 sent out ?

Nah, go ahead.

Paolo