[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] mips_malta: Clean up definition of flash me
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 5/5] mips_malta: Clean up definition of flash memory size somewhat |
Date: |
Tue, 5 Mar 2019 17:34:19 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 3/5/19 5:28 PM, Philippe Mathieu-Daudé wrote:
> From: Markus Armbruster <address@hidden>
>
> pflash_cfi01_register() takes a size in bytes, a block size in bytes
> and a number of blocks. mips_malta_init() passes BIOS_SIZE, 65536,
> FLASH_SIZE >> 16. Actually consistent only because BIOS_SIZE (defined
> in include/hw/mips/bios.h as (4 * MiB)) matches FLASH_SIZE (defined
> locally as 0x400000). Confusing all the same.
>
> Pass FLASH_SIZE instead of BIOS_SIZE.
>
> Cc: Aurelien Jarno <address@hidden>
> Cc: Aleksandar Rikalo <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
I forgot here:
Reviewed-by: Alex Bennée <address@hidden>
> [PMD: rebased]
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/mips/mips_malta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
> index 04788ff50a..a5726edaa7 100644
> --- a/hw/mips/mips_malta.c
> +++ b/hw/mips/mips_malta.c
> @@ -1280,7 +1280,7 @@ void mips_malta_init(MachineState *machine)
> #endif
> }
> fl = pflash_cfi01_register(FLASH_ADDRESS, NULL, "mips_malta.bios",
> - BIOS_SIZE,
> + FLASH_SIZE,
> pflash_blk,
> 65536, FLASH_SIZE >> 16,
> 4, 0x0000, 0x0000, 0x0000, 0x0000, be);
>
- Re: [Qemu-devel] [PATCH 1/5] hw/mips/malta: Fix the DEBUG_BOARD_INIT code, (continued)
[Qemu-devel] [PATCH 2/5] hw/mips/malta: Remove fl_sectors variable (used one single time), Philippe Mathieu-Daudé, 2019/03/05
[Qemu-devel] [PATCH 3/5] hw/mips/malta: Restrict 'bios_size' variable scope, Philippe Mathieu-Daudé, 2019/03/05
[Qemu-devel] [PATCH 4/5] hw/mips/malta: Only accept 'monitor' pflash of 4MiB, Philippe Mathieu-Daudé, 2019/03/05
[Qemu-devel] [PATCH 5/5] mips_malta: Clean up definition of flash memory size somewhat, Philippe Mathieu-Daudé, 2019/03/05
- Re: [Qemu-devel] [PATCH 5/5] mips_malta: Clean up definition of flash memory size somewhat,
Philippe Mathieu-Daudé <=
Re: [Qemu-devel] [PATCH 0/5] mips_malta: Clean up definition of flash memory size, Richard Henderson, 2019/03/05
Re: [Qemu-devel] [PATCH 0/5] mips_malta: Clean up definition of flash memory size, Aleksandar Markovic, 2019/03/06
Re: [Qemu-devel] [PATCH 0/5] mips_malta: Clean up definition of flash memory size, Markus Armbruster, 2019/03/06