|
| From: | Eric Blake |
| Subject: | Re: [Qemu-devel] [PATCH 1/5] lsi: use ldn_le_p()/stn_le_p() |
| Date: | Mon, 4 Mar 2019 12:40:50 -0600 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 3/4/19 12:09 PM, Sven Schnelle wrote:
Signed-off-by: Sven Schnelle <address@hidden>
The commit header says "what" (good), but the commit body says nothing at all (generally, it should say "why"). If you give your reviewers a reason why it is good to use the new functions, it makes it easier to apply your patch.
Also, don't forget to send a 0/5 cover letter when sending a patch series; you can have git do this for you with 'git config format.coverletter auto'. https://wiki.qemu.org/Contribute/SubmitAPatch has more hints for improved patch handling.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
| [Prev in Thread] | Current Thread | [Next in Thread] |