qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 2/2] CODING_STYLE: indent example code as all


From: Igor Mammedov
Subject: Re: [Qemu-devel] [PATCH v4 2/2] CODING_STYLE: indent example code as all others
Date: Thu, 28 Feb 2019 16:19:14 +0100

On Mon, 25 Feb 2019 09:25:30 +0800
Wei Yang <address@hidden> wrote:

> All the example code are indented with four spaces except this one.
> 
> Fix this by adding four spaces here.
> 
> Signed-off-by: Wei Yang <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

Reviewed-by: Igor Mammedov <address@hidden>

> ---
>  CODING_STYLE | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/CODING_STYLE b/CODING_STYLE
> index 1bccf4f865..e6d21dcd67 100644
> --- a/CODING_STYLE
> +++ b/CODING_STYLE
> @@ -137,10 +137,10 @@ block to a separate function altogether.
>  When comparing a variable for (in)equality with a constant, list the
>  constant on the right, as in:
>  
> -if (a == 1) {
> -    /* Reads like: "If a equals 1" */
> -    do_something();
> -}
> +    if (a == 1) {
> +        /* Reads like: "If a equals 1" */
> +        do_something();
> +    }
>  
>  Rationale: Yoda conditions (as in 'if (1 == a)') are awkward to read.
>  Besides, good compilers already warn users when '==' is mis-typed as '=',




reply via email to

[Prev in Thread] Current Thread [Next in Thread]