[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] trivial malloc to g_malloc in thunk
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH] trivial malloc to g_malloc in thunk |
Date: |
Thu, 28 Feb 2019 13:50:54 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Feb 28, 2019 at 07:12:45PM +0530, Aarushi Mehta wrote:
> Hi
>
> This is a trivial contribution part of the BiteSizedTasks on the wiki.
> I found this discussion
> http://git.corpit.ru/?p=qemu.git;a=commit;h=b45c03f585ea9bb1af76c73e82195418c294919d
> on migrating even g_malloc to g_new, is this not appropriate for the same?
> The wiki can presumably use an update regarding this.
This kind of question should not be in the commit message - it shoudl
go below the '---'
>
> Signed-off-by: Aarushi <address@hidden>
> ---
....here....
This lets people answer the question, without the question becoming
part of the git history.
> thunk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/thunk.c b/thunk.c
> index d5d8645cd4..03fb2abab7 100644
> --- a/thunk.c
> +++ b/thunk.c
> @@ -89,7 +89,7 @@ void thunk_register_struct(int id, const char *name, const
> argtype *types)
> for(i = 0;i < 2; i++) {
> offset = 0;
> max_align = 1;
> - se->field_offsets[i] = malloc(nb_fields * sizeof(int));
> + se->field_offsets[i] = g_malloc(nb_fields * sizeof(int));
Yes, this should use g_new0
> type_ptr = se->field_types;
> for(j = 0;j < nb_fields; j++) {
> size = thunk_type_size(type_ptr, i);
> --
> 2.17.1
>
>
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|