Re: [Qemu-devel] [PATCH v1 07/33] s390x/tcg: Implement VECTOR GENERATE MASK

[Richard Henderson]

On 2/26/19 1:16 PM, David Hildenbrand wrote:
>> +    tmp = tcg_temp_new_i64();
>> +    tcg_gen_movi_i64(tmp, mask);
>> +    gen_gvec_dup_i64(es, get_field(s->fields, v1), tmp);
> Richard, shall I better convert this into
> 
> switch (es) {
> case MO_8:
>       tcg_gen_gvec_dup8i(..., 16, 16, mask)
>       break;
> case MO_16:
>       tcg_gen_gvec_dup16i(..., 16, 16, mask)
>       break;
> ...
> };
> 
> ?

Yes, that would be better.

I see code in tcg/optimizer.c that should have propagated the constant, but
it's better to emit the correct opcode in the first place when it is easy like
this.

With that,
Reviewed-by: Richard Henderson <address@hidden

r~