Re: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
d3ad1848a6 target/riscv: Remaining rvc insn reuse 32 bit translators
af1913c05d target/riscv: Splice remaining compressed insn pairs for riscv32 vs 
riscv64
6963c921f9 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64
58c75d3141 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns
d084322875 target/riscv: Convert @cs_2 insns to share translation functions
c351eb0ae8 target/riscv: Remove decode_RV32_64G()
23deae3b9b target/riscv: Remove gen_system()
77ff803f8f target/riscv: Rename trans_arith to gen_arith
ae280bc4f1 target/riscv: Remove manual decoding of RV32/64M insn
a8c3d18049 target/riscv: Remove shift and slt insn manual decoding
4128d0ced1 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists
99e3fc2efd target/riscv: Move gen_arith_imm() decoding into trans_* functions
8dd27df30a target/riscv: Remove manual decoding from gen_store()
1e746316f3 target/riscv: Remove manual decoding from gen_load()
b1814e4382 target/riscv: Remove manual decoding from gen_branch()
0bb9dae337 target/riscv: Remove gen_jalr()
cefa65a0e5 target/riscv: Convert quadrant 2 of RVXC insns to decodetree
492885cb14 target/riscv: Convert quadrant 1 of RVXC insns to decodetree
4db7a126c0 target/riscv: Convert quadrant 0 of RVXC insns to decodetree
f4a72664f5 target/riscv: Convert RV priv insns to decodetree
4f16046c27 target/riscv: Convert RV64D insns to decodetree
53196e5d8a target/riscv: Convert RV32D insns to decodetree
70ed1de904 target/riscv: Convert RV64F insns to decodetree
94ab95eb96 target/riscv: Convert RV32F insns to decodetree
373e5f4d89 target/riscv: Convert RV64A insns to decodetree
5f8b81a2c0 target/riscv: Convert RV32A insns to decodetree
27a8c76421 target/riscv: Convert RVXM insns to decodetree
9de2f054f4 target/riscv: Convert RVXI csr insns to decodetree
2447efc130 target/riscv: Convert RVXI fence insns to decodetree
c3431cf3a3 target/riscv: Convert RVXI arithmetic insns to decodetree
959691a272 target/riscv: Convert RV64I load/store insns to decodetree
bb7f3b05c7 target/riscv: Convert RV32I load/store insns to decodetree
44dece7d64 target/riscv: Convert RVXI branch insns to decodetree
3397dd74ae target/riscv: Activate decodetree and implemnt LUI & AUIPC

=== OUTPUT BEGIN ===
1/34 Checking commit 3397dd74ae95 (target/riscv: Activate decodetree and 
implemnt LUI & AUIPC)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

ERROR: externs should be avoided in .c files
#125: FILE: target/riscv/translate.c:1884:
+bool decode_insn32(DisasContext *ctx, uint32_t insn);

total: 1 errors, 1 warnings, 125 lines checked

Patch 1/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/34 Checking commit 44dece7d64d8 (target/riscv: Convert RVXI branch insns to 
decodetree)
3/34 Checking commit bb7f3b05c7b4 (target/riscv: Convert RV32I load/store insns 
to decodetree)
4/34 Checking commit 959691a2728b (target/riscv: Convert RV64I load/store insns 
to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

total: 0 errors, 1 warnings, 76 lines checked

Patch 4/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/34 Checking commit c3431cf3a39b (target/riscv: Convert RVXI arithmetic insns 
to decodetree)
6/34 Checking commit 2447efc130a0 (target/riscv: Convert RVXI fence insns to 
decodetree)
7/34 Checking commit 9de2f054f47f (target/riscv: Convert RVXI csr insns to 
decodetree)
8/34 Checking commit 27a8c764212b (target/riscv: Convert RVXM insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 169 lines checked

Patch 8/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/34 Checking commit 5f8b81a2c0d2 (target/riscv: Convert RV32A insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 9/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/34 Checking commit 373e5f4d8968 (target/riscv: Convert RV64A insns to 
decodetree)
11/34 Checking commit 94ab95eb96d8 (target/riscv: Convert RV32F insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#78: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 11/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/34 Checking commit 70ed1de904b0 (target/riscv: Convert RV64F insns to 
decodetree)
13/34 Checking commit 53196e5d8a74 (target/riscv: Convert RV32D insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 13/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/34 Checking commit 4f16046c27c5 (target/riscv: Convert RV64D insns to 
decodetree)
15/34 Checking commit f4a72664f537 (target/riscv: Convert RV priv insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

total: 0 errors, 1 warnings, 214 lines checked

Patch 15/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/34 Checking commit 4db7a126c020 (target/riscv: Convert quadrant 0 of RVXC 
insns to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

ERROR: externs should be avoided in .c files
#251: FILE: target/riscv/translate.c:1072:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 231 lines checked

Patch 16/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

17/34 Checking commit 492885cb1452 (target/riscv: Convert quadrant 1 of RVXC 
insns to decodetree)
18/34 Checking commit cefa65a0e5f9 (target/riscv: Convert quadrant 2 of RVXC 
insns to decodetree)
19/34 Checking commit 0bb9dae3379f (target/riscv: Remove gen_jalr())
20/34 Checking commit b1814e438227 (target/riscv: Remove manual decoding from 
gen_branch())
21/34 Checking commit 1e746316f3f0 (target/riscv: Remove manual decoding from 
gen_load())
22/34 Checking commit 8dd27df30ae1 (target/riscv: Remove manual decoding from 
gen_store())
23/34 Checking commit 99e3fc2efdac (target/riscv: Move gen_arith_imm() decoding 
into trans_* functions)
24/34 Checking commit 4128d0ced126 (target/riscv: make ADD/SUB/OR/XOR/AND insn 
use arg lists)
25/34 Checking commit a8c3d18049c6 (target/riscv: Remove shift and slt insn 
manual decoding)
26/34 Checking commit ae280bc4f195 (target/riscv: Remove manual decoding of 
RV32/64M insn)
27/34 Checking commit 77ff803f8f10 (target/riscv: Rename trans_arith to 
gen_arith)
28/34 Checking commit 23deae3b9b0c (target/riscv: Remove gen_system())
29/34 Checking commit c351eb0ae8a5 (target/riscv: Remove decode_RV32_64G())
30/34 Checking commit d084322875cd (target/riscv: Convert @cs_2 insns to share 
translation functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

ERROR: externs should be avoided in .c files
#182: FILE: target/riscv/translate.c:548:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 164 lines checked

Patch 30/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

31/34 Checking commit 58c75d3141b1 (target/riscv: Convert @cl_d, @cl_w, @cs_d, 
@cs_w insns)
32/34 Checking commit 6963c921f9fd (target/riscv: Splice fsw_sd and flw_ld for 
riscv32 vs riscv64)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

total: 0 errors, 1 warnings, 309 lines checked

Patch 32/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/34 Checking commit af1913c05db8 (target/riscv: Splice remaining compressed 
insn pairs for riscv32 vs riscv64)
34/34 Checking commit d3ad1848a68b (target/riscv: Remaining rvc insn reuse 32 
bit translators)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden