[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/6] target/mips: Add emulation of MMI instru
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 2/6] target/mips: Add emulation of MMI instruction PCPYH |
|
Date: |
Tue, 26 Feb 2019 09:14:54 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/26/19 4:23 AM, Mateja Marjanovic wrote:
> + tcg_gen_andi_i64(t0, cpu_gpr[rt], mask);
> + tcg_gen_movi_i64(t1, 0);
> + tcg_gen_or_i64(t1, t0, t1);
> + tcg_gen_shli_i64(t0, t0, 16);
> + tcg_gen_or_i64(t1, t0, t1);
> + tcg_gen_shli_i64(t0, t0, 16);
> + tcg_gen_or_i64(t1, t0, t1);
> + tcg_gen_shli_i64(t0, t0, 16);
> + tcg_gen_or_i64(t1, t0, t1);
See previous review about this using 4x too many operations.
r~
- [Qemu-devel] [PATCH v2 0/6] target/mips: Add emulation of data communication MMI instructions, Mateja Marjanovic, 2019/02/26
- [Qemu-devel] [PATCH v2 4/6] target/mips: Add emulation of MMI instruction PCPYUD, Mateja Marjanovic, 2019/02/26
- [Qemu-devel] [PATCH v2 3/6] target/mips: Add emulation of MMI instruction PCPYLD, Mateja Marjanovic, 2019/02/26
- [Qemu-devel] [PATCH v2 6/6] target/mips: Add emulation of MMI instruction PEXCW, Mateja Marjanovic, 2019/02/26
- [Qemu-devel] [PATCH v2 1/6] target/mips: Preparing for adding MMI instructions, Mateja Marjanovic, 2019/02/26
- [Qemu-devel] [PATCH v2 2/6] target/mips: Add emulation of MMI instruction PCPYH, Mateja Marjanovic, 2019/02/26
- Re: [Qemu-devel] [PATCH v2 2/6] target/mips: Add emulation of MMI instruction PCPYH,
Richard Henderson <=
- [Qemu-devel] [PATCH v2 5/6] target/mips: Add emulation of MMI instruction PEXCH, Mateja Marjanovic, 2019/02/26