[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 03/11] hw/usb: don't set IN_ISDIR for inotify watch i
From: |
Daniel P . Berrangé |
Subject: |
[Qemu-devel] [PULL 03/11] hw/usb: don't set IN_ISDIR for inotify watch in MTP driver |
Date: |
Mon, 25 Feb 2019 12:31:03 +0000 |
IN_ISDIR is not a bit that one can request when registering a
watch with inotify_add_watch. Rather it is a bit that is set
automatically when reading events from the kernel.
Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Daniel P. Berrangé <address@hidden>
---
hw/usb/dev-mtp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index f1d20fa1b9..f0c52a476a 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -653,8 +653,7 @@ static void usb_mtp_inotify_cleanup(MTPState *s)
static int usb_mtp_add_watch(int inotifyfd, char *path)
{
- uint32_t mask = IN_CREATE | IN_DELETE | IN_MODIFY |
- IN_ISDIR;
+ uint32_t mask = IN_CREATE | IN_DELETE | IN_MODIFY;
return inotify_add_watch(inotifyfd, path, mask);
}
--
2.20.1
- [Qemu-devel] [PULL 00/11] Merge authz core patches, Daniel P . Berrangé, 2019/02/25
- [Qemu-devel] [PULL 02/11] qom: don't require user creatable objects to be registered, Daniel P . Berrangé, 2019/02/25
- [Qemu-devel] [PULL 01/11] util: add helper APIs for dealing with inotify in portable manner, Daniel P . Berrangé, 2019/02/25
- [Qemu-devel] [PULL 03/11] hw/usb: don't set IN_ISDIR for inotify watch in MTP driver,
Daniel P . Berrangé <=
- [Qemu-devel] [PULL 04/11] hw/usb: fix const-ness for string params in MTP driver, Daniel P . Berrangé, 2019/02/25
- [Qemu-devel] [PULL 06/11] authz: add QAuthZ object as an authorization base class, Daniel P . Berrangé, 2019/02/25
- [Qemu-devel] [PULL 05/11] hw/usb: switch MTP to use new inotify APIs, Daniel P . Berrangé, 2019/02/25
- [Qemu-devel] [PULL 07/11] authz: add QAuthZSimple object type for easy whitelist auth checks, Daniel P . Berrangé, 2019/02/25
- [Qemu-devel] [PULL 08/11] authz: add QAuthZList object type for an access control list, Daniel P . Berrangé, 2019/02/25
- [Qemu-devel] [PULL 10/11] authz: add QAuthZPAM object type for authorizing using PAM, Daniel P . Berrangé, 2019/02/25
- [Qemu-devel] [PULL 11/11] authz: delete existing ACL implementation, Daniel P . Berrangé, 2019/02/25