[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 03/10] block/dirty-bitmap: remove set/reset a
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 03/10] block/dirty-bitmap: remove set/reset assertions against enabled bit |
|
Date: |
Sat, 23 Feb 2019 15:11:15 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 2/22/19 6:06 PM, John Snow wrote:
> bdrv_set_dirty_bitmap and bdrv_reset_dirty_bitmap are only used as an
> internal API by the mirror and migration areas of our code. These
> calls modify the bitmap, but do so at the behest of QEMU and not the
> guest.
>
> Presently, these bitmaps are always "enabled" anyway, but there's no
> reason they have to be.
>
> Modify these internal APIs to drop this assertion.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> block/dirty-bitmap.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- Re: [Qemu-devel] [PATCH v3 05/10] nbd: change error checking order for bitmaps, (continued)
- [Qemu-devel] [PATCH v3 10/10] iotests: add busy/recording bit test to 124, John Snow, 2019/02/22
- [Qemu-devel] [PATCH v3 07/10] block/dirty-bitmaps: unify qmp_locked and user_locked calls, John Snow, 2019/02/22
- [Qemu-devel] [PATCH v3 03/10] block/dirty-bitmap: remove set/reset assertions against enabled bit, John Snow, 2019/02/22
- [Qemu-devel] [PATCH v3 08/10] block/dirty-bitmaps: move comment block, John Snow, 2019/02/22
- Re: [Qemu-devel] [PATCH v3 00/10] dirty-bitmaps: deprecate @status field, John Snow, 2019/02/25
- Re: [Qemu-devel] [PATCH v3 00/10] dirty-bitmaps: deprecate @status field, no-reply, 2019/02/27