Re: [Qemu-devel] [PATCH v3 0/3] target/arm: Reduce overhead of cpu_get_tb_cpu_state

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> Changes since v2:
>   * Do not cache VECLEN, VECSTRIDE, VFPEN.
>     These variables come from VFP_FPSCR and VFP_FPEXC, not from
>     system control registers.
>   * Move HANDLER and STACKCHECK to rebuild_hflags_a32,
>     instead of building them in rebuild_hflags_common.
>
> Changes since v1:
>   * Apparently I had started a last-minute API change, and failed to
>     covert all of the users, and also failed to re-test afterward.
>   * Retain assertions for --enable-debug-tcg.

I thought I was being clever by running our armhf test binaries on a
aarch64 image. However I have re-tested by doing a full armhf buster
install this time:

Tested-by: Alex Bennée <address@hidden>

>
>
> r~
>
>
>
> Richard Henderson (3):
>   target/arm: Split out recompute_hflags et al
>   target/arm: Rebuild hflags at el changes and MSR writes
>   target/arm: Rely on hflags correct in cpu_get_tb_cpu_state
>
>  target/arm/cpu.h           |  28 ++--
>  target/arm/helper.h        |   3 +
>  target/arm/internals.h     |   4 +
>  linux-user/syscall.c       |   1 +
>  target/arm/cpu.c           |   1 +
>  target/arm/helper-a64.c    |   3 +
>  target/arm/helper.c        | 266 ++++++++++++++++++++++---------------
>  target/arm/machine.c       |   1 +
>  target/arm/op_helper.c     |   1 +
>  target/arm/translate-a64.c |   6 +-
>  target/arm/translate.c     |  14 +-
>  11 files changed, 212 insertions(+), 116 deletions(-)


--
Alex Bennée