[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 09/13] block: Don't poll in bdrv_set_aio_context(
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH v2 09/13] block: Don't poll in bdrv_set_aio_context() |
Date: |
Wed, 20 Feb 2019 18:48:39 +0100 |
The explicit aio_poll() call in bdrv_set_aio_context() was added in
commit c2b6428d388 as a workaround for bdrv_drain() failing to achieve
to actually quiesce everything (specifically the NBD client code to
switch AioContext).
Now that the NBD client has been fixed to complete this operation during
bdrv_drain(), we don't need the workaround any more.
It was wrong anyway: aio_poll() must always be run in the home thread of
the AioContext.
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
block.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/block.c b/block.c
index 0c12632661..17bc1d3dca 100644
--- a/block.c
+++ b/block.c
@@ -5273,10 +5273,6 @@ void bdrv_set_aio_context(BlockDriverState *bs,
AioContext *new_context)
bdrv_parent_drained_begin(bs, NULL, false);
bdrv_drain(bs); /* ensure there are no in-flight requests */
- while (aio_poll(ctx, false)) {
- /* wait for all bottom halves to execute */
- }
-
bdrv_detach_aio_context(bs);
/* This function executes in the old AioContext so acquire the new one in
--
2.20.1
- [Qemu-devel] [PATCH v2 01/13] block-backend: Make blk_inc/dec_in_flight public, (continued)
[Qemu-devel] [PATCH v2 04/13] io: Make qio_channel_yield() interruptible, Kevin Wolf, 2019/02/20
[Qemu-devel] [PATCH v2 06/13] nbd: Move nbd_read_eof() to nbd/client.c, Kevin Wolf, 2019/02/20
[Qemu-devel] [PATCH v2 09/13] block: Don't poll in bdrv_set_aio_context(),
Kevin Wolf <=
[Qemu-devel] [PATCH v2 07/13] nbd: Use low-level QIOChannel API in nbd_read_eof(), Kevin Wolf, 2019/02/20
[Qemu-devel] [PATCH v2 08/13] nbd: Increase bs->in_flight during AioContext switch, Kevin Wolf, 2019/02/20
[Qemu-devel] [PATCH v2 10/13] block: Fix AioContext switch for drained node, Kevin Wolf, 2019/02/20
[Qemu-devel] [PATCH v2 11/13] test-bdrv-drain: AioContext switch in drained section, Kevin Wolf, 2019/02/20
[Qemu-devel] [PATCH v2 12/13] block: Use normal drain for bdrv_set_aio_context(), Kevin Wolf, 2019/02/20
[Qemu-devel] [PATCH v2 13/13] aio-posix: Assert that aio_poll() is always called in home thread, Kevin Wolf, 2019/02/20
Re: [Qemu-devel] [PATCH v2 00/13] block: bdrv_set_aio_context() related fixes, Kevin Wolf, 2019/02/25