Re: [Qemu-devel] [PATCH 01/10] pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02

[Markus Armbruster]

Philippe Mathieu-Daudé <address@hidden> writes:

> On 2/18/19 1:56 PM, Markus Armbruster wrote:
>> flash.h's incomplete struct pflash_t is completed both in
>> pflash_cfi01.c and in pflash_cfi02.c.  The complete types are
>> incompatible.  This can hide type errors, such as passing a pflash_t
>> created with pflash_cfi02_register() to pflash_cfi01_get_memory().
>> 
>> Furthermore, POSIX reserves typedef names ending with _t.
>> 
>> Rename the two structs to PFlashCFI01 and PFlashCFI02.
>
> Why not ParallelFlashCFIxx?

Feels a bit long, and we abbreviate to pflash pretty consistently.  That
said, I'm not particularly enamored with my choice of name :)

> Ideally ParallelFlashCFI would be an InterfaceInfo...

You mean TYPE_CFI_PFLASH0{1,2} should be children of an abstract parent?