Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

[Gerd Hoffmann]

On Mon, Feb 11, 2019 at 04:19:14AM +0100, BALATON Zoltan wrote:
> At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI
> gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and
> guests running on these and the PMON2000 firmware of the fulong2e
> expect this to be available. Fortunately these are very similar chips
> so they can be mostly emulated in the same device model. This patch
> adds basic emulation of these ATI VGA chips.
> 
> While this is incomplete and currently only enough to run the MIPS
> firmware and get console output with Linux,

Which linux driver is this?

If linux has a native driver it might make sense to also enable it on
x86.  Makes testing easier.

You can add the driver to default_list[] in vl.c, then you don't need
-vga none to remove the default vga when adding -device ati-vga.

>From a very brief look this looks sane overall, will have to find some
time for a more detailed review.

cheers,
  Gerd