[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 09/17] block/qcow2: use qemu_iovec_init_buf
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-devel] [PATCH v4 09/17] block/qcow2: use qemu_iovec_init_buf |
Date: |
Mon, 18 Feb 2019 17:09:18 +0300 |
Use new qemu_iovec_init_buf() instead of
qemu_iovec_init_external( ... , 1), which simplifies the code.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
---
block/qcow2.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 65a54c9ac6..b6d475229e 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -3894,7 +3894,6 @@ qcow2_co_pwritev_compressed(BlockDriverState *bs,
uint64_t offset,
{
BDRVQcow2State *s = bs->opaque;
QEMUIOVector hd_qiov;
- struct iovec iov;
int ret;
size_t out_len;
uint8_t *buf, *out_buf;
@@ -3960,11 +3959,7 @@ qcow2_co_pwritev_compressed(BlockDriverState *bs,
uint64_t offset,
goto fail;
}
- iov = (struct iovec) {
- .iov_base = out_buf,
- .iov_len = out_len,
- };
- qemu_iovec_init_external(&hd_qiov, &iov, 1);
+ qemu_iovec_init_buf(&hd_qiov, out_buf, out_len);
BLKDBG_EVENT(bs->file, BLKDBG_WRITE_COMPRESSED);
ret = bdrv_co_pwritev(bs->file, cluster_offset, out_len, &hd_qiov, 0);
@@ -3990,7 +3985,6 @@ qcow2_co_preadv_compressed(BlockDriverState *bs,
int ret = 0, csize, nb_csectors;
uint64_t coffset;
uint8_t *buf, *out_buf;
- struct iovec iov;
QEMUIOVector local_qiov;
int offset_in_cluster = offset_into_cluster(s, offset);
@@ -4002,9 +3996,7 @@ qcow2_co_preadv_compressed(BlockDriverState *bs,
if (!buf) {
return -ENOMEM;
}
- iov.iov_base = buf;
- iov.iov_len = csize;
- qemu_iovec_init_external(&local_qiov, &iov, 1);
+ qemu_iovec_init_buf(&local_qiov, buf, csize);
out_buf = qemu_blockalign(bs, s->cluster_size);
--
2.18.0
- [Qemu-devel] [PATCH v4 00/17] block: local qiov helper, Vladimir Sementsov-Ogievskiy, 2019/02/18
- [Qemu-devel] [PATCH v4 07/17] block/parallels: use QEMU_IOVEC_INIT_BUF, Vladimir Sementsov-Ogievskiy, 2019/02/18
- [Qemu-devel] [PATCH v4 16/17] hw/ide: drop iov field from IDEBufferedRequest, Vladimir Sementsov-Ogievskiy, 2019/02/18
- [Qemu-devel] [PATCH v4 04/17] block/backup: use qemu_iovec_init_buf, Vladimir Sementsov-Ogievskiy, 2019/02/18
- [Qemu-devel] [PATCH v4 08/17] block/qcow: use qemu_iovec_init_buf, Vladimir Sementsov-Ogievskiy, 2019/02/18
- [Qemu-devel] [PATCH v4 17/17] hw/ide: drop iov field from IDEDMA, Vladimir Sementsov-Ogievskiy, 2019/02/18
- [Qemu-devel] [PATCH v4 15/17] hw/ide: drop iov field from IDEState, Vladimir Sementsov-Ogievskiy, 2019/02/18
- [Qemu-devel] [PATCH v4 03/17] block/block-backend: use QEMU_IOVEC_INIT_BUF, Vladimir Sementsov-Ogievskiy, 2019/02/18
- [Qemu-devel] [PATCH v4 09/17] block/qcow2: use qemu_iovec_init_buf,
Vladimir Sementsov-Ogievskiy <=
- [Qemu-devel] [PATCH v4 02/17] block/io: use qemu_iovec_init_buf, Vladimir Sementsov-Ogievskiy, 2019/02/18
- [Qemu-devel] [PATCH v4 12/17] qemu-img: use qemu_iovec_init_buf, Vladimir Sementsov-Ogievskiy, 2019/02/18
- [Qemu-devel] [PATCH v4 01/17] block: enhance QEMUIOVector structure, Vladimir Sementsov-Ogievskiy, 2019/02/18
- [Qemu-devel] [PATCH v4 05/17] block/commit: use QEMU_IOVEC_INIT_BUF, Vladimir Sementsov-Ogievskiy, 2019/02/18
- [Qemu-devel] [PATCH v4 10/17] block/qed: use qemu_iovec_init_buf, Vladimir Sementsov-Ogievskiy, 2019/02/18
- [Qemu-devel] [PATCH v4 13/17] migration/block: use qemu_iovec_init_buf, Vladimir Sementsov-Ogievskiy, 2019/02/18
- [Qemu-devel] [PATCH v4 06/17] block/stream: use QEMU_IOVEC_INIT_BUF, Vladimir Sementsov-Ogievskiy, 2019/02/18
- [Qemu-devel] [PATCH v4 11/17] block/vmdk: use qemu_iovec_init_buf, Vladimir Sementsov-Ogievskiy, 2019/02/18
- [Qemu-devel] [PATCH v4 14/17] tests/test-bdrv-drain: use QEMU_IOVEC_INIT_BUF, Vladimir Sementsov-Ogievskiy, 2019/02/18