[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 17/18] qmp: Deprecate query-events in favor of query-
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 17/18] qmp: Deprecate query-events in favor of query-qmp-schema |
Date: |
Mon, 18 Feb 2019 15:06:06 +0100 |
query-events doesn't reflect compile-time configuration. Instead of
fixing that, deprecate the command in favor of query-qmp-schema.
Libvirt prefers query-qmp-schema as of commit 22d7222ec0 "qemu: caps:
Don't call 'query-events' when we probe events from QMP schema".
It'll be in the next release.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
---
monitor.c | 5 +++++
qapi/misc.json | 7 +++++--
qemu-deprecated.texi | 5 +++++
3 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/monitor.c b/monitor.c
index 1673db7015..33ccbf3957 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1099,6 +1099,11 @@ CommandInfoList *qmp_query_commands(Error **errp)
EventInfoList *qmp_query_events(Error **errp)
{
+ /*
+ * TODO This deprecated command is the only user of
+ * QAPIEvent_str() and QAPIEvent_lookup[]. When the command goes,
+ * they should go, too.
+ */
EventInfoList *info, *ev_list = NULL;
QAPIEvent e;
diff --git a/qapi/misc.json b/qapi/misc.json
index 82f9147353..98f59f828a 100644
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -318,12 +318,15 @@
##
# @query-events:
#
-# Return a list of supported QMP events by this server
+# Return information on QMP events.
#
-# Returns: A list of @EventInfo for all supported events
+# Returns: A list of @EventInfo.
#
# Since: 1.2.0
#
+# Note: This command is deprecated, because its output doesn't reflect
+# compile-time configuration. Use query-qmp-schema instead.
+#
# Example:
#
# -> { "execute": "query-events" }
diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index fe905551c5..45c57952da 100644
--- a/qemu-deprecated.texi
+++ b/qemu-deprecated.texi
@@ -82,6 +82,11 @@ Use ``device_add'' for hotplugging vCPUs instead of
``cpu-add''. See
documentation of ``query-hotpluggable-cpus'' for additional
details.
address@hidden query-events (since 4.0)
+
+The ``query-events'' command has been superseded by the more powerful
+and accurate ``query-qmp-schema'' command.
+
@section Human Monitor Protocol (HMP) commands
@subsection The hub_id parameter of 'hostfwd_add' / 'hostfwd_remove' (since
3.1)
--
2.17.2
- [Qemu-devel] [PULL 00/18] QAPI patches for 2019-02-18, Markus Armbruster, 2019/02/18
- [Qemu-devel] [PULL 17/18] qmp: Deprecate query-events in favor of query-qmp-schema,
Markus Armbruster <=
- [Qemu-devel] [PULL 02/18] qapi: Fix up documentation for recent commit a95291007b2, Markus Armbruster, 2019/02/18
- [Qemu-devel] [PULL 16/18] Revert "qapi-events: add 'if' condition to implicit event enum", Markus Armbruster, 2019/02/18
- [Qemu-devel] [PULL 15/18] qapi: remove qmp_unregister_command(), Markus Armbruster, 2019/02/18
- [Qemu-devel] [PULL 06/18] build-sys: move qmp-introspect per target, Markus Armbruster, 2019/02/18
- [Qemu-devel] [PULL 04/18] qapi: Prepare for system modules other than 'builtin', Markus Armbruster, 2019/02/18
- [Qemu-devel] [PULL 13/18] qapi: make query-cpu-model-expansion depend on s390 or x86, Markus Armbruster, 2019/02/18
- [Qemu-devel] [PULL 11/18] target.json: add a note about query-cpu* not being s390x-specific, Markus Armbruster, 2019/02/18
- [Qemu-devel] [PULL 09/18] qapi: make rtc-reset-reinjection and SEV depend on TARGET_I386, Markus Armbruster, 2019/02/18
- [Qemu-devel] [PULL 07/18] build: Deal with all of QAPI's .o in qapi/Makefile.objs, Markus Armbruster, 2019/02/18
- [Qemu-devel] [PULL 08/18] qapi: New module target.json, Markus Armbruster, 2019/02/18