Re: [Qemu-devel] [PATCH v2 0/6] tests: Add device unplug tests

[David Hildenbrand]

On 15.02.19 22:27, Michael S. Tsirkin wrote:
> On Fri, Feb 15, 2019 at 02:29:59PM +0100, David Hildenbrand wrote:
>> This is a set of tests to test basic device unplugging functionality for
>> - some PCI implementations
>> - CCW devices on s390x
>> - spapr memory and cpu core devices
>>
>> I plaed with ACPI CPU unplug but getting that to run with qtest is more
>> involved. (remove devices on reset, trick cpu-hotplug-legacy property,
>> somehow create cpu hotplug state objects ...). Well we no have at least
>> one unplug test for DIMMs and one for CPUs.
>>
>> @David, I dropped you t-b and r-b due to many changes but would be happy
>> to readd them ;)
> 
> 
> Series:
> Reviewed-by: Michael S. Tsirkin <address@hidden>
> 
> 
> I think it's mostly spapr things so feel free to merge through
> that tree.

Thanks, I'll address the minor review comments next week and most
probably resend on Monday. I also agree that spapr would be a good fit.


-- 

Thanks,

David / dhildenb