[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] SiFive RISC-V GPIO Device
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH] SiFive RISC-V GPIO Device |
Date: |
Wed, 13 Feb 2019 19:54:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2019-02-13 18:14, Peter Maydell wrote:
> On Wed, 13 Feb 2019 at 00:13, Alistair Francis <address@hidden> wrote:
>> I know the other RISC-V files don't do it, but this should go in the
>> hw/gpio directory instead of hw/riscv.
>
> It might be nice to move those existing riscv devices into
> their proper places at some point: should be a fairly easy
> cleanup patch if somebody wants to take it on. (Advice
> on what should live where available on request.)
If devices only work on riscv, they should IMHO stay in hw/riscv/. I
think hw/gpio/ and friends should primarily be used if a device is
shared between architectures. If they stay in hw/riscv/ it is way easier
to match the devices with wildcards in the MAINTAINERS file. Just my
0.02 € only, of course.
Thomas