[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 33/51] ppc: Express dependencies of the Sam460EX
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 33/51] ppc: Express dependencies of the Sam460EX machines with kconfig |
Date: |
Fri, 8 Feb 2019 05:30:07 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2019-02-08 00:16, BALATON Zoltan wrote:
> On Thu, 7 Feb 2019, Paolo Bonzini wrote:
>> From: Thomas Huth <address@hidden>
>>
>> Most of the dependencies are now directly selected by the SAM460EX
>> switch. We can drop CONFIG_VGA_CIRRUS since this device is already
>> selected automatically when CONFIG_PCI_DEVICES is set.
>>
>> Reviewed-by: BALATON Zoltan <address@hidden>
>> Reviewed-by: Paolo Bonzini <address@hidden>
>> Signed-off-by: Thomas Huth <address@hidden>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>> default-configs/ppc-softmmu.mak | 8 --------
>> hw/display/Kconfig | 1 +
>> hw/ppc/Kconfig | 11 +++++++++++
>> 3 files changed, 12 insertions(+), 8 deletions(-)
>>
>> diff --git a/default-configs/ppc-softmmu.mak
>> b/default-configs/ppc-softmmu.mak
>> index caaff60..fb43cba 100644
>> --- a/default-configs/ppc-softmmu.mak
>> +++ b/default-configs/ppc-softmmu.mak
>> @@ -25,14 +25,6 @@ CONFIG_PCI_EXPRESS=y
>>
>> # For Sam460ex
>> CONFIG_SAM460EX=y
>> -CONFIG_USB_EHCI_SYSBUS=y
>> -CONFIG_SM501=y
>> -CONFIG_IDE_SII3112=y
>> -CONFIG_AT24C=y
>> -CONFIG_BITBANG_I2C=y
>> -CONFIG_M41T80=y
>> -CONFIG_VGA_CIRRUS=y
>> -CONFIG_SMBUS_EEPROM=y
>>
>> # For Macs
>> CONFIG_MAC_OLDWORLD=y
>> diff --git a/hw/display/Kconfig b/hw/display/Kconfig
>> index 0f659e9..69f8a7e 100644
>> --- a/hw/display/Kconfig
>> +++ b/hw/display/Kconfig
>> @@ -29,6 +29,7 @@ config SII9022
>> config SSD0303
>> bool
>> depends on I2C
>> + select DDC
>
> What's SSD0303? It's not something sam460ex needs. Are you sure this
> hunk belongs to this patch?
That looks like a rebase error, inded. The line should belong to SM501
instead, see my original patch:
https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg08244.html
Thomas
- [Qemu-devel] [PATCH 22/51] vfio: express vfio dependencies with Kconfig, (continued)
- [Qemu-devel] [PATCH 22/51] vfio: express vfio dependencies with Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 23/51] virtio: express virtio dependencies with Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 25/51] isa: express SuperIO dependencies with Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 26/51] ssi: express dependencies with kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 29/51] i386-softmmu.mak: remove all CONFIG_* except boards definitions, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 31/51] ppc: Express dependencies of the 'prep' and '40p' machines with kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 30/51] ppc64: Express dependencies of 'pseries' and 'powernv' machines with kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 32/51] ppc: Express dependencies of the Mac machines with kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 33/51] ppc: Express dependencies of the Sam460EX machines with kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 34/51] ppc: Express dependencies of the embedded machines with kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 35/51] alpha-softmmu.mak: express dependencies with Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 39/51] m68k-softmmu.mak: express dependencies with Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 38/51] lm32-softmmu.mak: express dependencies with Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 43/51] or1k-softmmu.mak: express dependencies with Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 36/51] cris-softmmu.mak: express dependencies with Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 37/51] hppa-softmmu.mak: express dependencies with Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 45/51] sh4-softmmu.mak: express dependencies with Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 47/51] sparc64-softmmu.mak: express dependencies with Kconfig, Paolo Bonzini, 2019/02/07