Re: [Qemu-devel] [PULLv3 00/32] More work towards libslirp

[Peter Maydell]

On Tue, 5 Feb 2019 at 18:28, Samuel Thibault
<address@hidden> wrote:
>
> The following changes since commit 01a9a51ffaf4699827ea6425cb2b834a356e159d:
>
>   Merge remote-tracking branch 'remotes/kraxel/tags/ui-20190205-pull-request' 
> into staging (2019-02-05 14:01:29 +0000)
>
> are available in the Git repository at:
>
>   https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
>
> for you to fetch changes up to 1e924479dce65a26a7432bf5920f89c1bf957d74:
>
>   slirp: API is extern C (2019-02-05 20:27:27 +0200)
>
> ----------------------------------------------------------------
> More work towards libslirp
>

Format string issues for the Windows build:

/home/petmay01/qemu-for-merges/slirp/slirp.c: In function
'slirp_send_packet_all':
/home/petmay01/qemu-for-merges/slirp/slirp.c:1116:20: error: unknown
conversion type character 'z' in format [-Werror=format=]
         g_critical("Failed to send packet, ret: %zd", ret);
                    ^
/usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/glib-2.0/glib/gmessages.h:333:32:
note: in definition of macro 'g_critical'
                                __VA_ARGS__)
                                ^
/home/petmay01/qemu-for-merges/slirp/slirp.c:1116:20: error: too many
arguments for format [-Werror=format-extra-args]
         g_critical("Failed to send packet, ret: %zd", ret);
                    ^
/usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/glib-2.0/glib/gmessages.h:333:32:
note: in definition of macro 'g_critical'
                                __VA_ARGS__)
                                ^
/home/petmay01/qemu-for-merges/slirp/slirp.c:1118:21: error: unknown
conversion type character 'z' in format [-Werror=format=]
         DEBUG_ERROR("send_packet() didn't send all data: %zd < %zu", ret, len);
                     ^
/usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/glib-2.0/glib/gmessages.h:342:32:
note: in definition of macro 'g_debug'
                                __VA_ARGS__)
                                ^
/home/petmay01/qemu-for-merges/slirp/slirp.c:1118:9: note: in
expansion of macro 'DEBUG_ERROR'
         DEBUG_ERROR("send_packet() didn't send all data: %zd < %zu", ret, len);
         ^
/home/petmay01/qemu-for-merges/slirp/slirp.c:1118:21: error: unknown
conversion type character 'z' in format [-Werror=format=]
         DEBUG_ERROR("send_packet() didn't send all data: %zd < %zu", ret, len);
                     ^
/usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/glib-2.0/glib/gmessages.h:342:32:
note: in definition of macro 'g_debug'
                                __VA_ARGS__)
                                ^
/home/petmay01/qemu-for-merges/slirp/slirp.c:1118:9: note: in
expansion of macro 'DEBUG_ERROR'
         DEBUG_ERROR("send_packet() didn't send all data: %zd < %zu", ret, len);
         ^
/home/petmay01/qemu-for-merges/slirp/slirp.c:1118:21: error: too many
arguments for format [-Werror=format-extra-args]
         DEBUG_ERROR("send_packet() didn't send all data: %zd < %zu", ret, len);
                     ^
/usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/glib-2.0/glib/gmessages.h:342:32:
note: in definition of macro 'g_debug'
                                __VA_ARGS__)
                                ^
/home/petmay01/qemu-for-merges/slirp/slirp.c:1118:9: note: in
expansion of macro 'DEBUG_ERROR'
         DEBUG_ERROR("send_packet() didn't send all data: %zd < %zu", ret, len);
         ^
cc1: all warnings being treated as errors


All the other builds went OK.

thanks
-- PMM