Re: [Qemu-devel] [PATCH v3 15/17] Revert "qapi-events: add 'if' condition to implicit event enum"

[Markus Armbruster]

Marc-André Lureau <address@hidden> writes:

> Hi
>
> On Wed, Feb 6, 2019 at 7:17 PM Markus Armbruster <address@hidden> wrote:
>>
>> This reverts commit 7bd263490590ee6fcf34ecb6203437e22f6e5a9c.
>>
>> The commit applied the events' conditions to the members of enum
>> QAPIEvent.  Awkward, because it renders QAPIEvent unusable in
>> target-independent code as soon as we make an event target-dependent.
>
> Well, my solution didn't have this problem iirc. You could mention
> that by having target-specific event enums, we could solve this.

What about appending:

    Another option would be to split target-dependent parts off enum
    QAPIEvent into a target-dependent enum.  Doesn't seem worthwhile right
    now.

> It might be worth a FIXME too.

Well, the only thing that's broken is query-events, and I propose to
delete it instead of fixing it.

>> Reverting this has the following effects:
>>
>> * ui/vnc.c can remain target independent.
>>
>> * monitor_qapi_event_conf[] doesn't have to muck around with #ifdef.
>>
>> * query-events again doesn't reflect conditionals.  I'm going to
>>   deprecate it in favor of query-qmp-schema.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> But that's ok for now:
> Reviewed-by: Marc-André Lureau <address@hidden>

Thanks!