[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] multifd: Drop x-multifd-page-count paramete
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] multifd: Drop x-multifd-page-count parameter |
Date: |
Wed, 6 Feb 2019 15:20:57 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/02/2019 14:23, Juan Quintela wrote:
> Libvirt don't want to expose (and explain it). And testing looks like
> 128 is good for all use cases, so just drop it.
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> hmp.c | 7 -------
> migration/migration.c | 30 ------------------------------
> migration/migration.h | 1 -
> migration/ram.c | 13 ++++++++-----
> qapi/migration.json | 13 +------------
> 5 files changed, 9 insertions(+), 55 deletions(-)
>
...
> diff --git a/migration/migration.c b/migration/migration.c
> index f673486679..65df9b566e 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -81,7 +81,6 @@
> /* The delay time (in ms) between two COLO checkpoints */
> #define DEFAULT_MIGRATE_X_CHECKPOINT_DELAY (200 * 100)
> #define DEFAULT_MIGRATE_MULTIFD_CHANNELS 2
> -#define DEFAULT_MIGRATE_MULTIFD_PAGE_COUNT 128
Why do you update it in the previous patch to remove it in this one?
Thanks,
Laurent
Re: [Qemu-devel] [PATCH 2/4] multifd: Drop x-multifd-page-count parameter, Daniel P . Berrangé, 2019/02/07
[Qemu-devel] [PATCH 3/4] multifd: Drop x-, Juan Quintela, 2019/02/06
[Qemu-devel] [PATCH 4/4] tests: Add migration multifd test, Juan Quintela, 2019/02/06