Re: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1)

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/4] TPM patches for stable-3.0.0 (v3.0.1)
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
2ee3ca908c Merge remote-tracking branch 
'remotes/kraxel/tags/usb-20190130-pull-request' into staging
dc5e041976 usb-mtp: replace the homebrew write with qemu_write_full
88fa4028c7 usb-mtp: breakup MTP write into smaller chunks
a8f52aa296 usb-mtp: Reallocate buffer in multiples of MTP_WRITE_BUF_SZ
c8647e59bf usb: implement XHCI underrun/overrun events
a7d1054633 usb: XHCI shall not halt isochronous endpoints
51528c361e hw/usb: Fix LGPL information in the file headers
0f69b05cc7 usb: dev-mtp: close fd in usb_mtp_object_readdir()
1a34ece95d usb: assign unique serial numbers to hid devices

=== OUTPUT BEGIN ===
1/8 Checking commit 1a34ece95d33 (usb: assign unique serial numbers to hid 
devices)
2/8 Checking commit 0f69b05cc77c (usb: dev-mtp: close fd in 
usb_mtp_object_readdir())
3/8 Checking commit 51528c361e28 (hw/usb: Fix LGPL information in the file 
headers)
4/8 Checking commit a7d105463360 (usb: XHCI shall not halt isochronous 
endpoints)
5/8 Checking commit c8647e59bf33 (usb: implement XHCI underrun/overrun events)
ERROR: spaces required around that '-' (ctx:VxV)
#38: FILE: hw/usb/hcd-xhci.c:1960:
+                xhci_event(xhci, &ev, xhci->slots[epctx->slotid-1].intr);
                                                                ^

ERROR: spaces required around that '-' (ctx:VxV)
#47: FILE: hw/usb/hcd-xhci.c:2041:
+    xhci->slots[slotid-1].intr = 0;
                       ^

ERROR: spaces required around that '-' (ctx:VxV)
#66: FILE: hw/usb/hcd-xhci.c:2316:
+        xhci->slots[slotid-1].intr = get_field(islot_ctx[2], TRB_INTR);
                           ^

ERROR: spaces required around that '-' (ctx:VxV)
#67: FILE: hw/usb/hcd-xhci.c:2317:
+        set_field(&slot_ctx[2], xhci->slots[slotid-1].intr, TRB_INTR);
                                                   ^

total: 4 errors, 0 warnings, 48 lines checked

Patch 5/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/8 Checking commit a8f52aa296e7 (usb-mtp: Reallocate buffer in multiples of 
MTP_WRITE_BUF_SZ)
7/8 Checking commit 88fa4028c720 (usb-mtp: breakup MTP write into smaller 
chunks)
8/8 Checking commit dc5e0419769e (usb-mtp: replace the homebrew write with 
qemu_write_full)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden