[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 11/20] iotests: add iotest 236 for testing bitmap
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PULL 11/20] iotests: add iotest 236 for testing bitmap merge |
Date: |
Thu, 31 Jan 2019 09:55:12 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Am 31.01.2019 um 03:03 hat John Snow geschrieben:
> On 1/30/19 12:27 PM, Kevin Wolf wrote:
> > Am 14.01.2019 um 17:25 hat Eric Blake geschrieben:
> >> From: John Snow <address@hidden>
> >>
> >> New interface, new smoke test.
> >>
> >> Signed-off-by: John Snow <address@hidden>
> >> Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> >> Reviewed-by: Eric Blake <address@hidden>
> >> Message-Id: <address@hidden>
> >> [eblake: fix last-minute change to echo text]
> >> Signed-off-by: Eric Blake <address@hidden>
> >
> > This test fails for me (with Python 3) because I get a different dict
> > order.
> >
> > Probably related to the OrderedDict that qmp_log() uses, so log() uses
> > sort_keys=False and the unordered dicts that are contained in the outer
> > OrderedDict stay unordered.
> >
> > Kevin
> >
>
> OK, the problem is that ordered_kwargs() is not recursively ordering
> those kwargs beneath list entries, so transactions are avoiding the sort.
>
> Patch coming up, thank you for the report and my apologies for breaking
> iotests so often this cycle.
>
> (While I'm here, how do you configure iotests to use your python3
> binary? I tried at configure time but that breaks the build for me with
> some "magic number" errors. I could toy with it after by editing
> common.env, but should the build work with python3?)
Yes, just at configure time:
./configure --target-list=x86_64-softmmu --python=/usr/bin/python3
I'm building and running tests in-tree, if that makes a difference.
But maybe it's actually not so bad if at least one of us still tests
with Python 2 as long as we haven't officially removed support for
that...
Kevin
- [Qemu-devel] [PULL 03/20] blockdev: n-ary bitmap merge, (continued)
- [Qemu-devel] [PULL 03/20] blockdev: n-ary bitmap merge, Eric Blake, 2019/01/14
- [Qemu-devel] [PULL 10/20] iotests: implement pretty-print for log and qmp_log, Eric Blake, 2019/01/14
- [Qemu-devel] [PULL 09/20] iotests: change qmp_log filters to expect QMP objects only, Eric Blake, 2019/01/14
- [Qemu-devel] [PULL 08/20] iotests: remove default filters from qmp_log, Eric Blake, 2019/01/14
- [Qemu-devel] [PULL 07/20] iotests: add qmp recursive sorting function, Eric Blake, 2019/01/14
- [Qemu-devel] [PULL 12/20] qemu-nbd: Rename 'exp' variable clashing with math::exp() symbol, Eric Blake, 2019/01/14
- [Qemu-devel] [PULL 11/20] iotests: add iotest 236 for testing bitmap merge, Eric Blake, 2019/01/14
- [Qemu-devel] [PULL 13/20] nbd: Add some error case testing to iotests 223, Eric Blake, 2019/01/14
- [Qemu-devel] [PULL 14/20] nbd: Forbid nbd-server-stop when server is not running, Eric Blake, 2019/01/14
- [Qemu-devel] [PULL 15/20] nbd: Only require disabled bitmap for read-only exports, Eric Blake, 2019/01/14
- [Qemu-devel] [PULL 16/20] nbd: Merge nbd_export_set_name into nbd_export_new, Eric Blake, 2019/01/14
- [Qemu-devel] [PULL 18/20] nbd: Remove x-nbd-server-add-bitmap, Eric Blake, 2019/01/14
- [Qemu-devel] [PULL 19/20] nbd: Merge nbd_export_bitmap into nbd_export_new, Eric Blake, 2019/01/14
- [Qemu-devel] [PULL 17/20] nbd: Allow bitmap export during QMP nbd-server-add, Eric Blake, 2019/01/14
- [Qemu-devel] [PULL 20/20] qemu-nbd: Add --bitmap=NAME option, Eric Blake, 2019/01/14
- Re: [Qemu-devel] [PULL 00/20] NBD patches through 2019-01-14, Peter Maydell, 2019/01/15