[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] gdbstub: Fix i386/x86_64 machine description an
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] gdbstub: Fix i386/x86_64 machine description and add control registers |
|
Date: |
Thu, 24 Jan 2019 10:13:57 +0000 |
On Thu, 24 Jan 2019 at 04:08, Doug Gale <address@hidden> wrote:
>
> Signed-off-by: Doug Gale <address@hidden>
> ---
> configure | 4 +-
> gdb-xml/i386-32bit-core.xml | 65 -----------
> gdb-xml/i386-32bit-sse.xml | 52 ---------
> gdb-xml/i386-32bit.xml | 184 ++++++++++++++++++++++++++++++-
> gdb-xml/i386-64bit-core.xml | 73 -------------
> gdb-xml/i386-64bit-sse.xml | 60 -----------
> gdb-xml/i386-64bit.xml | 210 +++++++++++++++++++++++++++++++++++-
> target/i386/cpu.c | 4 +-
> target/i386/gdbstub.c | 186 +++++++++++++++++++++++++++++++-
> 9 files changed, 573 insertions(+), 265 deletions(-)
> delete mode 100644 gdb-xml/i386-32bit-core.xml
> delete mode 100644 gdb-xml/i386-32bit-sse.xml
> delete mode 100644 gdb-xml/i386-64bit-core.xml
> delete mode 100644 gdb-xml/i386-64bit-sse.xml
Could you provide a commit message that explains what's
wrong with the machine description we have (ie what bug
or bugs this change is fixing) and why deleting half
the xml files is the right way to fix it, please?
Does the "add control registers" part need to be in
the same patch, or is it a separate feature which
could be in its own patch ?
thanks
-- PMM