[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5] log: Make glib logging go through QEMU
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v5] log: Make glib logging go through QEMU |
Date: |
Tue, 22 Jan 2019 14:13:41 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, Jan 21, 2019 at 06:04:35PM +0100, Christophe Fergeau wrote:
> This commit adds a qemu_init_logging() helper which calls
> g_log_set_default_handler() so that glib logs (g_log, g_warning, ...)
> are handled similarly to other QEMU logs. This means they will get a
> timestamp if timestamps are enabled, and they will go through the
> monitor if one is configured.
> This commit also adds a call to qemu_init_logging() to the binaries
> installed by QEMU.
> glib debug messages are enabled through G_MESSAGES_DEBUG similarly to
> glib default log handler.
>
> At the moment, this change will mostly impact SPICE logging if your
> spice version is >= 0.14.1. With older spice versions, this is not going
> to work as expected, but will not have any ill effect, so this call is
> not conditional on the SPICE version.
>
> Signed-off-by: Christophe Fergeau <address@hidden>
> Reviewed-by: Daniel P. Berrangé <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> ---
> One more iteration of the patch as it hit CI failures
> (https://patchew.org/QEMU/address@hidden/ )
> Only difference from v4 is the addition of #include "qemu/error-report.h"
> in bsd-user and linux-user.
>
>
> bsd-user/main.c | 2 ++
> include/qemu/error-report.h | 2 ++
> linux-user/main.c | 2 ++
> qemu-img.c | 1 +
> qemu-io.c | 1 +
> qemu-nbd.c | 1 +
> scsi/qemu-pr-helper.c | 1 +
> util/qemu-error.c | 47 +++++++++++++++++++++++++++++++++++++
> vl.c | 1 +
> 9 files changed, 58 insertions(+)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature