[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] roms: add the edk2 project as a git submodu
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] roms: add the edk2 project as a git submodule |
Date: |
Tue, 22 Jan 2019 11:51:55 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 01/21/19 20:45, Philippe Mathieu-Daudé wrote:
> On 1/21/19 7:41 PM, Laszlo Ersek wrote:
>> On 01/21/19 12:25, Philippe Mathieu-Daudé wrote:
>>> I suggest the following change, Daniel/Alex what do you think?
>>>
>>> -- >8 --
>>> diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh
>>> index 98ca0f2737..5441fe3385 100755
>>> --- a/scripts/git-submodule.sh
>>> +++ b/scripts/git-submodule.sh
>>> @@ -71,7 +71,7 @@ update)
>>> exit 0
>>> fi
>>>
>>> - $GIT submodule update --init $modules 1>/dev/null
>>> + $GIT submodule update --init --recursive $modules 1>/dev/null
>>> test $? -ne 0 && error "failed to update modules"
>>>
>>> $GIT submodule status $modules > "${substat}"
>>> ---
>>
>> This shouldn't make a difference, as edk2 is not a nested submodule of
>> another submodule; it is a submodule directly under the main
>> superproject, i.e. QEMU.
>
> OK (as long as we don't want to build OVMF within QEMU to run QEMU tests).
I think if / whenever we bundle OVMF binaries with QEMU, there'll be a
two step process (like with other roms); maintainers will (re)build the
binaries and commit/merge them, and tests will use the bundled binaries
as they are.
Thanks
Laszlo
[Qemu-devel] [PATCH 2/5] roms: build the EfiRom utility from the roms/edk2 submodule, Laszlo Ersek, 2019/01/18
[Qemu-devel] [PATCH 4/5] tests/uefi-test-tools: add build scripts, Laszlo Ersek, 2019/01/18