[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v3 28/43] hw/pci/Makefile.objs: make pcie co
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [RFC PATCH v3 28/43] hw/pci/Makefile.objs: make pcie configurable |
Date: |
Fri, 18 Jan 2019 14:28:36 -0500 |
On Fri, Jan 18, 2019 at 06:28:37PM +0100, Paolo Bonzini wrote:
>
>
> I think PCIE should depend on PCI or something like this.
> That's because there are places in code that test CONFIG_PCI,
> you want PCIE to enable them as well.
>
>
> I agree, it should select PCI, so that PCIe bridges only need to select PCIE
> (the model in QEMU is that you enable boards and pluggable devices; everything
> else, especially buses, is then selected automatically based on whether any
> controllers/bridges are enabled for those buses).
>
> Paolo
>
OK, and I also think we should rename it PCIE -> PCI_EXPRESS_, this way
everything PCI starts with PCI.
--
MST
- [Qemu-devel] [RFC PATCH v3 19/43] hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc, (continued)
- [Qemu-devel] [RFC PATCH v3 19/43] hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc, Yang Zhong, 2019/01/18
- [Qemu-devel] [RFC PATCH v3 20/43] hw/tricore/Makefile.objs: Create CONFIG_* for tricore, Yang Zhong, 2019/01/18
- [Qemu-devel] [RFC PATCH v3 22/43] minikconfig: add AST, Yang Zhong, 2019/01/18
- [Qemu-devel] [RFC PATCH v3 27/43] ide: express dependencies with Kconfig, Yang Zhong, 2019/01/18
- [Qemu-devel] [RFC PATCH v3 24/43] hw/display: make edid configurable, Yang Zhong, 2019/01/18
- [Qemu-devel] [RFC PATCH v3 23/43] minikconfig: add semantic analysis, Yang Zhong, 2019/01/18
- [Qemu-devel] [RFC PATCH v3 26/43] build: switch to Kconfig, Yang Zhong, 2019/01/18
- [Qemu-devel] [RFC PATCH v3 28/43] hw/pci/Makefile.objs: make pcie configurable, Yang Zhong, 2019/01/18
[Qemu-devel] [RFC PATCH v3 25/43] kconfig: introduce kconfig files, Yang Zhong, 2019/01/18
[Qemu-devel] [RFC PATCH v3 30/43] build: convert sound.mak to Kconfig, Yang Zhong, 2019/01/18
[Qemu-devel] [RFC PATCH v3 31/43] build: convert usb.mak to Kconfig, Yang Zhong, 2019/01/18
[Qemu-devel] [RFC PATCH v3 29/43] build: convert pci.mak to Kconfig, Yang Zhong, 2019/01/18