[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/5] tests/libqos: rename qpci_init_pc and qpci_
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/5] tests/libqos: rename qpci_init_pc and qpci_init_spapr functions |
Date: |
Fri, 18 Jan 2019 13:45:39 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 18/01/19 13:23, Thomas Huth wrote:
>> diff --git a/tests/libqos/pci-pc.h b/tests/libqos/pci-pc.h
>> index 491eeac..84cc300 100644
>> --- a/tests/libqos/pci-pc.h
>> +++ b/tests/libqos/pci-pc.h
>> @@ -16,7 +16,14 @@
>> #include "libqos/pci.h"
>> #include "libqos/malloc.h"
>>
>> -QPCIBus *qpci_init_pc(QTestState *qts, QGuestAllocator *alloc);
>> +/* qpci_new_pc():
>> +* this function creates a new QPCIBusPC object,
>
> Hmm, you did not notice my previous review, did you? See:
>
> https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg01417.html
No, I missed it.
> I'd also be fine if we keep "init" instead
> of "new"... it's quite a bit of code churn ...
It matches QOM's object_new vs. object_initialize.
Paolo
- [Qemu-devel] [PATCH 0/5] qtest driver framework (core only), Paolo Bonzini, 2019/01/15
- [Qemu-devel] [PATCH 3/5] tests: remove rule for nonexisting qdev-monitor-test, Paolo Bonzini, 2019/01/15
- [Qemu-devel] [PATCH 2/5] tests/libqos: rename qpci_init_pc and qpci_init_spapr functions, Paolo Bonzini, 2019/01/15
- [Qemu-devel] [PATCH 1/5] tests/libqos: introduce virtio_start_device, Paolo Bonzini, 2019/01/15
- [Qemu-devel] [PATCH 4/5] tests/libqos: embed allocators instead of malloc-ing them separately, Paolo Bonzini, 2019/01/15
- [Qemu-devel] [PATCH 5/5] tests: qgraph API for the qtest driver framework, Paolo Bonzini, 2019/01/15