[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Xen-devel] [PATCH] hw/block/xen: use proper format str
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [Xen-devel] [PATCH] hw/block/xen: use proper format string for printing sectors |
Date: |
Thu, 17 Jan 2019 08:21:10 +0000 |
User-agent: |
mu4e 1.1.0; emacs 26.1.91 |
Andrew Cooper <address@hidden> writes:
> On 16/01/2019 12:13, Alex Bennée wrote:
>> The %lu format string is different depending on the host architecture
>> which causes builds like the debian-armhf-cross build to fail. Use the
>> correct PRi64 format string.
>>
>> Signed-off-by: Alex Bennée <address@hidden>
>> ---
>> hw/block/xen-block.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c
>> index be28b63442..a636487b3e 100644
>> --- a/hw/block/xen-block.c
>> +++ b/hw/block/xen-block.c
>> @@ -215,7 +215,7 @@ static void xen_block_realize(XenDevice *xendev, Error
>> **errp)
>>
>> xen_device_backend_printf(xendev, "sector-size", "%u",
>> conf->logical_block_size);
>> - xen_device_backend_printf(xendev, "sectors", "%lu",
>> + xen_device_backend_printf(xendev, "sectors", "%"PRIi64,
>
> PRIu64.
>
> You've changed the signed-ness of what gets printed.
I was deliberate as:
int64_t blk_getlength(BlockBackend *blk);
although I have to admit a signed block length doesn't make much sense
to me. At least it isn't going to overflow and will show-up if the block
length is ever negative.
>
> ~Andrew
--
Alex Bennée