qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 0/4] Introduce attributes for timers subsyste


From: Pavel Dovgalyuk
Subject: Re: [Qemu-devel] [PATCH v3 0/4] Introduce attributes for timers subsystem and remove QEMU_CLOCK_VIRTUAL_EXT clock type
Date: Wed, 16 Jan 2019 09:16:00 +0300

> From: Artem Pisarenko [mailto:address@hidden
> > It seems, that this approach is not always correct.
> > Now timerlist_deadline_ns uses all virtual timers for deadline calculation 
> > (including
> external
> > ones).
> > qemu_start_warp_timer uses the deadline for setting warp timer (which 
> > should be
> deterministic).
> > Therefore warp timer may become non-deterministic and replay may behave 
> > differently compared
> to
> > recording phase.
> >
> > We have to rollback these or improve somehow to avoid non-determinism.
> 
> I dont understand how this approach would even introduce
> non-determinism. I'm not sure about aspects of timers subsystem you
> mentioned, assuming that maybe we missed something when tried to
> optimize. But this has nothing to do with determinism as long as we
> treat all virtual clock timers as deterministic, regardless of
> EXTERNAL attribute being set or not. They are intended to be used as
> such by design, aren't? This attribute was introduced purely to avoid
> extra events in log.

Right, but deadline calculation and icount warp events (that are written into 
the log too)
depend on the active virtual timers. Therefore external ones may affect icount 
warp
operation sequence.

Pavel Dovgalyuk




reply via email to

[Prev in Thread] Current Thread [Next in Thread]