[Qemu-devel] [Bug 1777252] Re: tests/Makefile.include trying to add linking library '-lutil' that break the build on Solaris

[Peter Maydell]

The condition we use in configure to decide whether to add -lutil to
libs_softmmu is "not Darwin and not MinGW and not Solaris and not
Haiku"...

I think the thing we're trying to get from libutil is openpty(), which
is in that library for Linux and the BSDs. It's not in libutil for OSX
(though since OSX has a libutil anyway it's harmless that it gets linked
in). For Windows we avoid code paths that use openpty(), and Solaris
doesn't have openpty() at all so we have to hand-roll our own
implementation in util/qemu-openpty.c.

I think the cleanest fix to this problem is to have a configure test
that checks "does openpty() require -lutil?", and then use the answer to
that both to decide whether to add -lutil to libs_softmmu and to decide
whether to add -lutil to the link line for this test binary.

PS: Thanks for the offer of Solaris hardware access. We may be able to
take you up on that but it would also require some time from somebody on
our end to set things up to use it. The other possible option is to have
one of the free-solaris-equivalents set up as a VM to run tests in in
the same way we do for the BSDs in tests/vm.

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1777252

Title:
  tests/Makefile.include trying to add linking library '-lutil' that
  break the build on Solaris

Status in QEMU:
  New

Bug description:
  Building script 'tests/Makefile.include' contains following code
  ```
  ifeq ($(CONFIG_POSIX),y)
  LIBS += -lutil
  endif
  ```

  library -lutil is not available on Solaris, so the building will failed, like
  ```
  ld: fatal: library -lutil: not found
  make: *** [SOMEWHERE/src/qemu-2.12.0/rules.mak:121: qemu-nbd] Error 1
  ```

  Commenting those code out fixed the error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1777252/+subscriptions