Re: [Qemu-devel] [PATCH] qemu.py: Fix error message when qemu dies from signal

[Eric Blake]

On 1/14/19 5:04 AM, Philippe Mathieu-Daudé wrote:
> Hi Eric,
> 
> On 1/11/19 9:13 PM, Eric Blake wrote:
>> When qemu dies from a signal, the python code gets a negative
>> value for exitcode; but signal numbers are positive.  Copy the
>> pattern used in qemu-iotests/iotests.py for reporting a positive
>> value.
>>
>> CC: address@hidden
>> Signed-off-by: Eric Blake <address@hidden>
>> ---
>>  scripts/qemu.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/qemu.py b/scripts/qemu.py
>> index 6e3b0e67719..0a5e02eb56e 100644
>> --- a/scripts/qemu.py
>> +++ b/scripts/qemu.py
>> @@ -351,7 +351,7 @@ class QEMUMachine(object):
>>                  command = ' '.join(self._qemu_full_args)
>>              else:
>>                  command = ''
>> -            LOG.warn(msg, exitcode, command)
>> +            LOG.warn(msg, -exitcode, command)
> 
> What about displaying signal name directly?

If you want to do that, it should be a separate patch, and fix
iotests.py at the same time.


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature