[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches
From: |
Programmingkid |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches |
Date: |
Fri, 28 Dec 2018 19:12:03 -0500 |
> On Dec 28, 2018, at 3:05 PM, Kővágó Zoltán <address@hidden> wrote:
>
> On 2018-12-28 01:46, Programmingkid wrote:
>>
>>> On Dec 27, 2018, at 8:33 AM, Kővágó Zoltán <address@hidden> wrote:
>>>
>>> Hi,
>>>
>>> I've pushed it to my github (modulo some random fixes not yet on the
>>> mailing list):
>>> https://github.com/DirtYiCE/qemu/tree/audio-51-2018
>>>
>>> I don't have a mac so I have no idea whether it works or not.
>>>
>>> Regards,
>>> Zoltan
>>>
>>> On 2018-12-26 12:24, Programmingkid wrote:
>>>>
>>>>> On Dec 23, 2018, at 3:52 PM, address@hidden wrote:
>>>>>
>>>>> Message: 4
>>>>> Date: Sun, 23 Dec 2018 21:51:36 +0100
>>>>> From: "=?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?="
>>>>> <address@hidden>
>>>>> To: address@hidden
>>>>> Cc: Gerd Hoffmann <address@hidden>
>>>>> Subject: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches
>>>>> Message-ID: <address@hidden>
>>>>> Content-Type: text/plain; charset=UTF-8
>>>>>
>>>>> Hi,
>>>>>
>>>>> I've updated my audio patchset to the current git master. Other than that
>>>>> not
>>>>> much happened since my last update [1], fixed a few small problems that I
>>>>> noticed while rebasing my patches.
>>>>>
>>>>> Please review.
>>>>
>>>> <snip>
>>>>
>>>> Hi I would like to run your patches. Do you have a repository that I may
>>>> clone?
>>>>
>>>> Also have you been able to test these patches using a Mac OS X guest yet?
>>>>
>>>> Thank you.
>>>>
>>>
>>
>> Hi, thanks for the link. This is what I did:
>>
>> - git clone https://github.com/DirtYiCE/qemu.git
>> - git checkout audio-51-2018
>> - ./configure --target-list=ppc-softmmu
>> - make -j 4
>>
>> The result was unfortunately some errors:
>>
>> CC audio/coreaudio.o
>> audio/coreaudio.c:413:49: error: unknown type name 'HWVocieOut'; did you mean
>> 'HWVoiceOut'?
>> COREAUDIO_WRAPPER_FUNC(get_buffer_out, void *, (HWVocieOut *hw, size_t
>> *size),
>> ^~~~~~~~~~
>> HWVoiceOut
>>
>>
>> audio/coreaudio.c:578:29: error: passing 'struct audio_pcm_info' to
>> parameter of
>> incompatible type 'struct audio_pcm_info *'; take the address with &
>> coreaudio_get_flags(hw->info, as);
>> ^~~~~~~~
>> &
>>
>>
>
> Hi,
>
> I pushed an updated version, it should fix the compile errors (hopefully).
>
> Regards,
> Zoltan
Thank you for the update. I tested this series using a Mac OS 10.4 and Windows
2000 guest. Both were using a USB sound card. The sound that comes out of my
speakers is demonic! It is the loudest, scariest sound I have ever heard. I'm
sorry but this patch series ruins the USB sound card.
I am happy to test out any future updates that you make this patch series.
Thank you.
- [Qemu-devel] [PATCH v2 50/52] usb-audio: do not count on avail bytes actually available, (continued)
- [Qemu-devel] [PATCH v2 50/52] usb-audio: do not count on avail bytes actually available, Kővágó, Zoltán, 2018/12/23
- [Qemu-devel] [PATCH v2 49/52] paaudio: channel-map option, Kővágó, Zoltán, 2018/12/23
- [Qemu-devel] [PATCH v2 52/52] usbaudio: change playback counters to 64 bit, Kővágó, Zoltán, 2018/12/23
- Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches, Philippe Mathieu-Daudé, 2018/12/25
- Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches, Programmingkid, 2018/12/26
- Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches, Kővágó Zoltán, 2018/12/27
- Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches, Programmingkid, 2018/12/27
- Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches, Kővágó Zoltán, 2018/12/28
- Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches,
Programmingkid <=
- Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches, Zoltán Kővágó, 2018/12/28
- Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches, Programmingkid, 2018/12/28
- Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches, Kővágó Zoltán, 2018/12/31
Re: [Qemu-devel] [PATCH v2 00/52] Audio 5.1 patches, Philippe Mathieu-Daudé, 2018/12/27