qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 5/6] target/mips: MXU: Add handlers for max/min


From: Aleksandar Markovic
Subject: Re: [Qemu-devel] [PATCH 5/6] target/mips: MXU: Add handlers for max/min instructions
Date: Thu, 27 Dec 2018 20:14:26 +0000

> From: Janeczek, Craig <address@hidden>

> > +        /* return resulting byte to its original position */
> > +        tcg_gen_shri_i32(t0, t0, 24);
> 
> Should be a shift of 16 here
> tcg_gen_shri_i32(t0, t0, 16);

You are right, for this and the next three hints. Will be fixed in v2.

Thanks,
Aleksandar


reply via email to

[Prev in Thread] Current Thread [Next in Thread]