Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/3] dmg: fixing reading in dmg

[Julio Faracco]

The series looks good to me.

I tested with existing DMGs and DMGs that I created by myself.
Both are working fine now.

Reviewed-by: Julio Faracco <address@hidden>

Em dom, 23 de dez de 2018 às 01:01, yuchenlin <address@hidden>
escreveu:

> There are two bugs in dmg reading.
>
> First, it may hang in binary search. this problem is solved by patch 1.
> Second, because of lacking zero chunk table, reading zero sector will
> return EIO. thie problem is solved by patch 2 and 3.
>
> Thanks
>
> v1 - >v2:
> * fix typos in patch 1
> * add patch 2 and patch 3
>
> yuchenlin (3):
>   dmg: fix binary search
>   dmg: use enumeration type instead of hard coding number
>   dmg: don't skip zero chunk
>
>  block/dmg.c | 25 +++++++++++++++----------
>  1 file changed, 15 insertions(+), 10 deletions(-)
>
> --
> 2.17.1
>
>
>