qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] ui: vnc: finish removing TABs


From: no-reply
Subject: Re: [Qemu-devel] [PATCH] ui: vnc: finish removing TABs
Date: Mon, 24 Dec 2018 03:23:18 -0800 (PST)

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH] ui: vnc: finish removing TABs

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
df43c3d ui: vnc: finish removing TABs

=== OUTPUT BEGIN ===
Checking PATCH 1/1: ui: vnc: finish removing TABs...
ERROR: braces {} are necessary for all arms of this statement
#63: FILE: ui/vnc-enc-hextile-template.h:49:
+                    if (irow[i] == bg)
[...]
+                    else if (irow[i] == fg)
[...]

ERROR: braces {} are necessary for all arms of this statement
#65: FILE: ui/vnc-enc-hextile-template.h:51:
+                    else if (irow[i] == fg)
[...]

ERROR: braces {} are necessary for all arms of this statement
#73: FILE: ui/vnc-enc-hextile-template.h:59:
+        if (n_colors > 2)
[...]

ERROR: braces {} are necessary for all arms of this statement
#143: FILE: ui/vnc-enc-hextile-template.h:95:
+                    if (min_x == -1)
[...]

ERROR: braces {} are necessary for all arms of this statement
#169: FILE: ui/vnc-enc-hextile-template.h:117:
+        if (!*has_bg || *last_bg != bg)
[...]

ERROR: braces {} are necessary for all arms of this statement
#192: FILE: ui/vnc-enc-hextile-template.h:127:
+                    if (irow[i] == bg)
[...]

WARNING: Block comments use a leading /* on a separate line
#268: FILE: ui/vnc-enc-hextile-template.h:175:
+            /* we really don't have to invalidate either the bg or fg

WARNING: Block comments use * on subsequent lines
#269: FILE: ui/vnc-enc-hextile-template.h:176:
+            /* we really don't have to invalidate either the bg or fg
+               but we've lost the old values.  oh well. */

WARNING: Block comments use a trailing */ on a separate line
#269: FILE: ui/vnc-enc-hextile-template.h:176:
+               but we've lost the old values.  oh well. */

ERROR: braces {} are necessary for all arms of this statement
#298: FILE: ui/vnc-enc-hextile-template.h:192:
+        if (flags & 0x02)
[...]

ERROR: braces {} are necessary for all arms of this statement
#300: FILE: ui/vnc-enc-hextile-template.h:194:
+        if (flags & 0x04)
[...]

WARNING: Block comments use a trailing */ on a separate line
#336: FILE: ui/vnc-enc-zywrle.h:56:
+        {0x0000FF00, 0x00FFFFFF, 0x00FFFFFF}, */

ERROR: "(foo*)" should be "(foo *)"
#627: FILE: ui/vnc-enc-zywrle.h:217:
+        r = (((uint8_t*)src)[S_1]<< 1)& 0xF8;                           \

ERROR: spaces required around that '<<' (ctx:VxW)
#627: FILE: ui/vnc-enc-zywrle.h:217:
+        r = (((uint8_t*)src)[S_1]<< 1)& 0xF8;                           \
                                  ^

ERROR: spaces required around that '&' (ctx:VxW)
#627: FILE: ui/vnc-enc-zywrle.h:217:
+        r = (((uint8_t*)src)[S_1]<< 1)& 0xF8;                           \
                                       ^

ERROR: "(foo*)" should be "(foo *)"
#628: FILE: ui/vnc-enc-zywrle.h:218:
+        g = (((uint8_t*)src)[S_1]<< 6) | (((uint8_t*)src)[S_0]>> 2);    \

ERROR: spaces required around that '<<' (ctx:VxW)
#628: FILE: ui/vnc-enc-zywrle.h:218:
+        g = (((uint8_t*)src)[S_1]<< 6) | (((uint8_t*)src)[S_0]>> 2);    \
                                  ^

ERROR: spaces required around that '>>' (ctx:VxW)
#628: FILE: ui/vnc-enc-zywrle.h:218:
+        g = (((uint8_t*)src)[S_1]<< 6) | (((uint8_t*)src)[S_0]>> 2);    \
                                                               ^

ERROR: "(foo*)" should be "(foo *)"
#631: FILE: ui/vnc-enc-zywrle.h:220:
+        b =  (((uint8_t*)src)[S_0]<< 3)& 0xF8;                          \

ERROR: spaces required around that '<<' (ctx:VxW)
#631: FILE: ui/vnc-enc-zywrle.h:220:
+        b =  (((uint8_t*)src)[S_0]<< 3)& 0xF8;                          \
                                   ^

ERROR: spaces required around that '&' (ctx:VxW)
#631: FILE: ui/vnc-enc-zywrle.h:220:
+        b =  (((uint8_t*)src)[S_0]<< 3)& 0xF8;                          \
                                        ^

ERROR: "(foo*)" should be "(foo *)"
#644: FILE: ui/vnc-enc-zywrle.h:228:
+        ((uint8_t*)dst)[S_1] = (uint8_t)((r >> 1)|(g >> 6));            \

ERROR: spaces required around that '|' (ctx:VxV)
#644: FILE: ui/vnc-enc-zywrle.h:228:
+        ((uint8_t*)dst)[S_1] = (uint8_t)((r >> 1)|(g >> 6));            \
                                                  ^

ERROR: "(foo*)" should be "(foo *)"
#645: FILE: ui/vnc-enc-zywrle.h:229:
+        ((uint8_t*)dst)[S_0] = (uint8_t)(((b >> 3)|(g << 2))& 0xFF);    \

ERROR: spaces required around that '|' (ctx:VxV)
#645: FILE: ui/vnc-enc-zywrle.h:229:
+        ((uint8_t*)dst)[S_0] = (uint8_t)(((b >> 3)|(g << 2))& 0xFF);    \
                                                   ^

ERROR: spaces required around that '&' (ctx:VxW)
#645: FILE: ui/vnc-enc-zywrle.h:229:
+        ((uint8_t*)dst)[S_0] = (uint8_t)(((b >> 3)|(g << 2))& 0xFF);    \
                                                             ^

ERROR: "(foo*)" should be "(foo *)"
#654: FILE: ui/vnc-enc-zywrle.h:236:
+        r = ((uint8_t*)src)[S_1] & 0xF8;                                \

ERROR: "(foo*)" should be "(foo *)"
#655: FILE: ui/vnc-enc-zywrle.h:237:
+        g = (((uint8_t*)src)[S_1]<< 5) | (((uint8_t*)src)[S_0] >> 3);   \

ERROR: spaces required around that '<<' (ctx:VxW)
#655: FILE: ui/vnc-enc-zywrle.h:237:
+        g = (((uint8_t*)src)[S_1]<< 5) | (((uint8_t*)src)[S_0] >> 3);   \
                                  ^

ERROR: "(foo*)" should be "(foo *)"
#658: FILE: ui/vnc-enc-zywrle.h:239:
+        b = (((uint8_t*)src)[S_0]<< 3) & 0xF8;                          \

ERROR: spaces required around that '<<' (ctx:VxW)
#658: FILE: ui/vnc-enc-zywrle.h:239:
+        b = (((uint8_t*)src)[S_0]<< 3) & 0xF8;                          \
                                  ^

ERROR: "(foo*)" should be "(foo *)"
#671: FILE: ui/vnc-enc-zywrle.h:247:
+        ((uint8_t*)dst)[S_1] = (uint8_t)(r | (g >> 5));                 \

ERROR: "(foo*)" should be "(foo *)"
#672: FILE: ui/vnc-enc-zywrle.h:248:
+        ((uint8_t*)dst)[S_0] = (uint8_t)(((b >> 3)|(g << 3)) & 0xFF);   \

ERROR: spaces required around that '|' (ctx:VxV)
#672: FILE: ui/vnc-enc-zywrle.h:248:
+        ((uint8_t*)dst)[S_0] = (uint8_t)(((b >> 3)|(g << 3)) & 0xFF);   \
                                                   ^

ERROR: "(foo*)" should be "(foo *)"
#682: FILE: ui/vnc-enc-zywrle.h:255:
+        r = ((uint8_t*)src)[L_2];             \

ERROR: "(foo*)" should be "(foo *)"
#683: FILE: ui/vnc-enc-zywrle.h:256:
+        g = ((uint8_t*)src)[L_1];             \

ERROR: "(foo*)" should be "(foo *)"
#684: FILE: ui/vnc-enc-zywrle.h:257:
+        b = ((uint8_t*)src)[L_0];             \

ERROR: "(foo*)" should be "(foo *)"
#691: FILE: ui/vnc-enc-zywrle.h:261:
+        ((uint8_t*)dst)[L_2] = (uint8_t)r;            \

ERROR: "(foo*)" should be "(foo *)"
#692: FILE: ui/vnc-enc-zywrle.h:262:
+        ((uint8_t*)dst)[L_1] = (uint8_t)g;            \

ERROR: "(foo*)" should be "(foo *)"
#693: FILE: ui/vnc-enc-zywrle.h:263:
+        ((uint8_t*)dst)[L_0] = (uint8_t)b;            \

ERROR: spaces required around that '<<' (ctx:VxV)
#735: FILE: ui/vnc-enc-zywrle.h:460:
+                s = 1<<l;
                      ^

ERROR: "(foo*)" should be "(foo *)"
#752: FILE: ui/vnc-enc-zywrle.h:474:
+        r = ((int8_t*)src)[2];                  \

ERROR: "(foo*)" should be "(foo *)"
#753: FILE: ui/vnc-enc-zywrle.h:475:
+        g = ((int8_t*)src)[1];                  \

ERROR: "(foo*)" should be "(foo *)"
#754: FILE: ui/vnc-enc-zywrle.h:476:
+        b = ((int8_t*)src)[0];                  \

ERROR: "(foo*)" should be "(foo *)"
#762: FILE: ui/vnc-enc-zywrle.h:481:
+        ((int8_t*)dst)[2] = (int8_t)r;        \

ERROR: "(foo*)" should be "(foo *)"
#763: FILE: ui/vnc-enc-zywrle.h:482:
+        ((int8_t*)dst)[1] = (int8_t)g;        \

ERROR: "(foo*)" should be "(foo *)"
#764: FILE: ui/vnc-enc-zywrle.h:483:
+        ((int8_t*)dst)[0] = (int8_t)b;        \

total: 43 errors, 4 warnings, 778 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]