[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 23/28] qdev: all globals are now user-provide
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v7 23/28] qdev: all globals are now user-provided |
Date: |
Fri, 21 Dec 2018 16:26:45 +0100 |
On Fri, 21 Dec 2018 13:04:05 +0400
Marc-André Lureau <address@hidden> wrote:
> All globals are now either provided via -global or through -cpu
> features (CPU features are implemented by registering globals).
>
> If the global isn't being used, it should warn in either case.
>
> We can thus consider that all global_props are "user-provided"
> globals. No need to track this per-globals anymore.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Igor Mammedov <address@hidden>
> ---
> include/hw/qdev-core.h | 3 --
> hw/core/qdev-properties.c | 4 ---
> tests/test-qdev-global-props.c | 57 ++++------------------------------
> vl.c | 1 -
> 4 files changed, 6 insertions(+), 59 deletions(-)
Reviewed-by: Cornelia Huck <address@hidden>
- Re: [Qemu-devel] [PATCH v7 18/28] compat: replace PC_COMPAT_2_2 & HW_COMPAT_2_2 macros, (continued)
- [Qemu-devel] [PATCH v7 17/28] compat: replace PC_COMPAT_2_3 & HW_COMPAT_2_3 macros, Marc-André Lureau, 2018/12/21
- [Qemu-devel] [PATCH v7 19/28] compat: replace PC_COMPAT_2_1 & HW_COMPAT_2_1 macros, Marc-André Lureau, 2018/12/21
- [Qemu-devel] [PATCH v7 20/28] include: remove compat.h, Marc-André Lureau, 2018/12/21
- [Qemu-devel] [PATCH v7 21/28] compat: remove remaining PC_COMPAT macros, Marc-André Lureau, 2018/12/21
- [Qemu-devel] [PATCH v7 23/28] qdev: all globals are now user-provided, Marc-André Lureau, 2018/12/21
- Re: [Qemu-devel] [PATCH v7 23/28] qdev: all globals are now user-provided,
Cornelia Huck <=
- [Qemu-devel] [PATCH v7 24/28] qdev-props: convert global_props to GPtrArray, Marc-André Lureau, 2018/12/21
- [Qemu-devel] [PATCH v7 22/28] qdev: make a separate helper function to apply compat properties, Marc-André Lureau, 2018/12/21
- [Qemu-devel] [PATCH v7 25/28] qdev-props: remove errp from GlobalProperty, Marc-André Lureau, 2018/12/21
- [Qemu-devel] [PATCH v7 26/28] qdev-props: call object_apply_global_props(), Marc-André Lureau, 2018/12/21
- [Qemu-devel] [PATCH v7 27/28] arm: replace instance_post_init(), Marc-André Lureau, 2018/12/21