[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 02/11] block/dirty-bitmap: remove assertion f
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 02/11] block/dirty-bitmap: remove assertion from restore |
|
Date: |
Wed, 19 Dec 2018 20:41:34 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 12/19/18 8:29 PM, John Snow wrote:
When making a backup of a dirty bitmap (for transactions), we want to
restore that backup whether or not the bitmap is enabled or not.
drop one of the two 'or not'
It is perfectly valid to write into bitmaps that are disabled. It is
only illegitimate for the guest to have done so.
Remove this assertion.
Signed-off-by: John Snow <address@hidden>
---
block/dirty-bitmap.c | 1 -
1 file changed, 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [Qemu-devel] [PATCH v5 00/11] bitmaps: remove x- prefix from QMP api, John Snow, 2018/12/19
- [Qemu-devel] [PATCH v5 01/11] blockdev: abort transactions in reverse order, John Snow, 2018/12/19
- [Qemu-devel] [PATCH v5 02/11] block/dirty-bitmap: remove assertion from restore, John Snow, 2018/12/19
- [Qemu-devel] [PATCH v5 03/11] blockdev: n-ary bitmap merge, John Snow, 2018/12/19
- [Qemu-devel] [PATCH v5 04/11] block: remove 'x' prefix from experimental bitmap APIs, John Snow, 2018/12/19
- [Qemu-devel] [PATCH v5 06/11] iotests: add filter_generated_node_ids, John Snow, 2018/12/19
- [Qemu-devel] [PATCH v5 05/11] iotests.py: don't abort if IMGKEYSECRET is undefined, John Snow, 2018/12/19
- [Qemu-devel] [PATCH v5 08/11] iotests: remove default filters from qmp_log, John Snow, 2018/12/19