Re: [Qemu-devel] [PATCH 1/3] ui: install logo icons to $prefix/share/icons

[Daniel P . Berrangé]

On Wed, Dec 19, 2018 at 08:20:23AM +0100, Gerd Hoffmann wrote:
> On Tue, Dec 18, 2018 at 02:26:27PM +0000, Daniel P. Berrangé wrote:
> > QEMU currently installs loogs to $prefix/share/qemu/ which means no GUI
> > toolkit or applications can find them by default.
> > 
> > The accepted standards for desktop applications declare that application
> > logos / icons should be installed under $prefix/share/icons, so use this
> > directory location.
> > 
> > Pre-rendered icons are provided at the standard sizes expected for GUI
> > applications, along with the scalable SVG, to ensure maximum portability.
> > 
> > Signed-off-by: Daniel P. Berrangé <address@hidden>
> > ---
> >  Makefile                                       |  13 ++++++++++++-
> >  configure                                      |   2 ++
> >  ui/gtk.c                                       |  17 +++++------------
> >  .../qemu_logo_no_text.svg => ui/icons/qemu.svg |   0
> >  ui/icons/qemu_128x128.png                      | Bin 0 -> 7761 bytes
> >  ui/icons/qemu_16x16.png                        | Bin 0 -> 751 bytes
> >  ui/icons/qemu_24x24.png                        | Bin 0 -> 1167 bytes
> >  ui/icons/qemu_256x256.png                      | Bin 0 -> 16216 bytes
> >  .../qemu-icon.bmp => ui/icons/qemu_32x32.bmp   | Bin
> >  ui/icons/qemu_32x32.png                        | Bin 0 -> 1656 bytes
> >  ui/icons/qemu_48x48.png                        | Bin 0 -> 2604 bytes
> >  ui/icons/qemu_512x512.png                      | Bin 0 -> 34609 bytes
> >  ui/icons/qemu_64x64.png                        | Bin 0 -> 3588 bytes
> 
> How did you create the png files?
> Can you drop a script or Makefile for that into the ui/icons directory?

I used GIMP so that it created high quality antialiased pngs.

> Should we commit them to git, or generate at build time?
> Is the tool used something we can expect to be installed?

I tried using ImageMagick to convert SVG to PNG but the results
were really poor compared to GIMP - very fuzzy. Running with
-verbose I can see it is invoking inkscape to atually do the
conversion, and it tells inkscape to export a small image which
it then resizes, hence the quality loss. Also I think InkScape
is getting a bit unreasonable for a standard QEMU developer
install.

The icons are small enough that we shouldn't really worry about
having pre-rendered icons in GIT IMHO. They're not ever going to
change unless we replace our logo again.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|