qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 07/13] qapi: make s390 commands depend on TARGET


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 07/13] qapi: make s390 commands depend on TARGET_S390X
Date: Tue, 18 Dec 2018 19:00:43 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Marc-André Lureau <address@hidden> writes:

> Signed-off-by: Marc-André Lureau <address@hidden>
> Acked-by: Cornelia Huck <address@hidden>
> ---
[...]
> diff --git a/qapi/target.json b/qapi/target.json
> index f277b69a2a..d751e1623a 100644
> --- a/qapi/target.json
> +++ b/qapi/target.json
> @@ -7,6 +7,8 @@
>  
>  { 'pragma': { 'top-unit': 'target' } }
>  
> +{ 'include': 'misc.json' }
> +

misc.json is a bit of a kitchen sink.  I'd prefer not to include it
here, but instead factor out the bits we actually need into a new .json.
I suspect that would be an improvement all by itself.

>  ##
>  # @rtc-reset-reinjection:
>  #
[...]



reply via email to

[Prev in Thread] Current Thread [Next in Thread]