qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [QEMU-devel][PATCH v3] aio-posix: Fix concurrent aio_po


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [QEMU-devel][PATCH v3] aio-posix: Fix concurrent aio_poll/set_fd_handler.
Date: Tue, 18 Dec 2018 15:32:07 +0000
User-agent: Mutt/1.10.1 (2018-07-13)

On Mon, Dec 17, 2018 at 05:48:47PM +0100, address@hidden wrote:
> From: Remy Noel <address@hidden>
> 
> It is possible for an io_poll callback to be concurrently executed along
> with an aio_set_fd_handlers. This can cause all sorts of problems, like
> a NULL callback or a bad opaque pointer.
> 
> This changes set_fd_handlers so that it no longer modify existing handlers
> entries and instead, always insert those after having proper initialisation.
> 
> Also, we do not call aio_epoll_update for deleted handlers as this has
> no impact whatsoever.
> 
> Signed-off-by: Remy Noel <address@hidden>

Tested-by: Stefan Hajnoczi <address@hidden>

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]