[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 0/3] Fix strncpy() warnings for GCC8 new -Wstring
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-devel] [PATCH v2 0/3] Fix strncpy() warnings for GCC8 new -Wstringop-truncation |
Date: |
Tue, 18 Dec 2018 12:03:30 +0100 |
GCC 8 new warning prevents builds to success since quite some time.
First report on the mailing list is in July 2018:
https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03723.html
Various intents has been sent to fix this:
- Incorrectly using g_strlcpy()
https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03705.html
https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03706.html
- Using assert() and strpadcpy()
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg03938.html
- Use #pragma GCC diagnostic ignored "-Wstringop-truncation"
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html
- adding an inline wrapper with said pragma in there
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html
- -Wno-stringop-truncation is the makefile
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html
This series replace the strncpy() calls by strpadcpy() which seemed
to me the saniest option.
Regards,
Phil.
Marc-André Lureau (1):
hw/acpi: Replace strncpy() by strpadcpy(pad='\0')
Philippe Mathieu-Daudé (2):
block/sheepdog: Replace strncpy() by strpadcpy(pad='\0')
migration: Replace strncpy() by strpadcpy(pad='\0')
block/sheepdog.c | 6 +++---
hw/acpi/aml-build.c | 6 ++++--
hw/acpi/core.c | 13 +++++++------
migration/global_state.c | 4 ++--
4 files changed, 16 insertions(+), 13 deletions(-)
--
2.17.2
- [Qemu-devel] [PATCH v2 0/3] Fix strncpy() warnings for GCC8 new -Wstringop-truncation,
Philippe Mathieu-Daudé <=