[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v11 06/10] file-posix: reset fallocate-related flags
From: |
Anton Nefedov |
Subject: |
[Qemu-devel] [PATCH v11 06/10] file-posix: reset fallocate-related flags without CONFIG_FALLOCATE* |
Date: |
Tue, 18 Dec 2018 07:57:40 +0000 |
these flags currently affect nothing without CONFIG_FALLOCATE*, so it's
not a bug. Fixing it makes possible to adjust supported zero flag
BDRV_REQ_ALLOCATE regardless of configuration (in the following patch).
Signed-off-by: Anton Nefedov <address@hidden>
---
block/file-posix.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index d8f0b93752..a65e464cbc 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -1488,9 +1488,7 @@ static ssize_t
handle_aiocb_write_zeroes_block(RawPosixAIOData *aiocb)
static int handle_aiocb_write_zeroes(void *opaque)
{
RawPosixAIOData *aiocb = opaque;
-#if defined(CONFIG_FALLOCATE) || defined(CONFIG_XFS)
BDRVRawState *s = aiocb->bs->opaque;
-#endif
#ifdef CONFIG_FALLOCATE
int64_t len;
#endif
@@ -1514,6 +1512,8 @@ static int handle_aiocb_write_zeroes(void *opaque)
}
s->has_write_zeroes = false;
}
+#else
+ s->has_write_zeroes = false;
#endif
#ifdef CONFIG_FALLOCATE_PUNCH_HOLE
@@ -1533,6 +1533,8 @@ static int handle_aiocb_write_zeroes(void *opaque)
s->has_discard = false;
}
}
+#else
+ s->has_discard = false;
#endif
#ifdef CONFIG_FALLOCATE
@@ -1546,6 +1548,8 @@ static int handle_aiocb_write_zeroes(void *opaque)
}
s->has_fallocate = false;
}
+#else
+ s->has_fallocate = false;
#endif
return -ENOTSUP;
--
2.17.1
- [Qemu-devel] [PATCH v11 00/10] qcow2: cluster space preallocation, Anton Nefedov, 2018/12/18
- [Qemu-devel] [PATCH v11 01/10] mirror: inherit supported write/zero flags, Anton Nefedov, 2018/12/18
- [Qemu-devel] [PATCH v11 02/10] blkverify: set supported write/zero flags, Anton Nefedov, 2018/12/18
- [Qemu-devel] [PATCH v11 03/10] quorum: set supported write flags, Anton Nefedov, 2018/12/18
- [Qemu-devel] [PATCH v11 06/10] file-posix: reset fallocate-related flags without CONFIG_FALLOCATE*,
Anton Nefedov <=
- [Qemu-devel] [PATCH v11 05/10] block: treat BDRV_REQ_ALLOCATE as serialising, Anton Nefedov, 2018/12/18
- [Qemu-devel] [PATCH v11 04/10] block: introduce BDRV_REQ_ALLOCATE flag, Anton Nefedov, 2018/12/18
- [Qemu-devel] [PATCH v11 08/10] block: support BDRV_REQ_ALLOCATE in passthrough drivers, Anton Nefedov, 2018/12/18
- [Qemu-devel] [PATCH v11 09/10] qcow2: skip writing zero buffers to empty COW areas, Anton Nefedov, 2018/12/18
- [Qemu-devel] [PATCH v11 07/10] file-posix: support BDRV_REQ_ALLOCATE, Anton Nefedov, 2018/12/18