[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 06/31] hw/smbios: Restrict access to "hw/smbios/ipmi.
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 06/31] hw/smbios: Restrict access to "hw/smbios/ipmi.h" |
Date: |
Mon, 17 Dec 2018 23:17:01 -0500 |
From: Philippe Mathieu-Daudé <address@hidden>
All the consumers of "hw/smbios/ipmi.h" are located in hw/smbios/.
There is no need to have this include publicly exposed,
reduce the visibility by moving it in hw/smbios/.
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
include/hw/smbios/ipmi.h => hw/smbios/smbios_ipmi.h | 0
hw/smbios/smbios.c | 2 +-
hw/smbios/smbios_type_38-stub.c | 2 +-
hw/smbios/smbios_type_38.c | 2 +-
4 files changed, 3 insertions(+), 3 deletions(-)
rename include/hw/smbios/ipmi.h => hw/smbios/smbios_ipmi.h (100%)
diff --git a/include/hw/smbios/ipmi.h b/hw/smbios/smbios_ipmi.h
similarity index 100%
rename from include/hw/smbios/ipmi.h
rename to hw/smbios/smbios_ipmi.h
diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c
index 04811279a0..6fe5be3586 100644
--- a/hw/smbios/smbios.c
+++ b/hw/smbios/smbios.c
@@ -28,7 +28,7 @@
#include "hw/loader.h"
#include "exec/cpu-common.h"
#include "smbios_build.h"
-#include "hw/smbios/ipmi.h"
+#include "smbios_ipmi.h"
/* legacy structures and constants for <= 2.0 machines */
struct smbios_header {
diff --git a/hw/smbios/smbios_type_38-stub.c b/hw/smbios/smbios_type_38-stub.c
index 5b83c9b1f1..fc4516bc8a 100644
--- a/hw/smbios/smbios_type_38-stub.c
+++ b/hw/smbios/smbios_type_38-stub.c
@@ -8,7 +8,7 @@
*/
#include "qemu/osdep.h"
-#include "hw/smbios/ipmi.h"
+#include "smbios_ipmi.h"
void smbios_build_type_38_table(void)
{
diff --git a/hw/smbios/smbios_type_38.c b/hw/smbios/smbios_type_38.c
index 56e8609c00..d84e87d608 100644
--- a/hw/smbios/smbios_type_38.c
+++ b/hw/smbios/smbios_type_38.c
@@ -9,10 +9,10 @@
#include "qemu/osdep.h"
#include "hw/ipmi/ipmi.h"
-#include "hw/smbios/ipmi.h"
#include "hw/smbios/smbios.h"
#include "qemu/error-report.h"
#include "smbios_build.h"
+#include "smbios_ipmi.h"
/* SMBIOS type 38 - IPMI */
struct smbios_type_38 {
--
MST
- [Qemu-devel] [PULL 00/31] pci, pc, virtio: fixes, features, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 01/31] pcie: set link state inactive/active after hot unplug/plug, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 02/31] pc:piix4: Update smbus I/O space after a migration, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 03/31] virtio: Helper for registering virtio device types, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 04/31] virtio: Provide version-specific variants of virtio PCI devices, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 05/31] tests: Remove unused include, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 06/31] hw/smbios: Restrict access to "hw/smbios/ipmi.h",
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 07/31] hw/smbios: Remove "smbios_ipmi.h", Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 08/31] hw/smbios: Move to the hw/firmware/ subdirectory, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 09/31] hw/pci-bridge: Fix invalid free(), Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 10/31] pcie: Create enums for link speed and width, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 13/31] pcie: Add link speed and width fields to PCIESlot, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 11/31] pci: Sync PCIe downstream port LNKSTA on read, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 12/31] qapi: Define PCIe link speed and width properties, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 16/31] vfio/pci: Remove PCIe Link Status emulation, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 15/31] pcie: Allow generic PCIe root port to specify link speed and width, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 14/31] pcie: Fill PCIESlot link fields to support higher speeds and widths, Michael S. Tsirkin, 2018/12/17