Re: [Qemu-devel] [PATCH qemu v3] ppc/spapr: Receive and store device tree blob from SLOF

[Alexey Kardashevskiy]

On 18/12/2018 13:09, David Gibson wrote:
> On Mon, Dec 17, 2018 at 05:21:33PM +1100, David Gibson wrote:
>> On Fri, Dec 14, 2018 at 12:55:20PM +1100, Alexey Kardashevskiy wrote:
>>> SLOF receives a device tree and updates it with various properties
>>> before switching to the guest kernel and QEMU is not aware of any changes
>>> made by SLOF. Since there is no real RTAS (QEMU implements it), it makes
>>> sense to pass the SLOF final device tree to QEMU to let it implement
>>> RTAS related tasks better, such as PCI host bus adapter hotplug.
>>>
>>> Specifially, now QEMU can find out the actual XICS phandle (for PHB
>>> hotplug) and the RTAS linux,rtas-entry/base properties (for firmware
>>> assisted NMI - FWNMI).
>>>
>>> This stores the initial DT blob in the sPAPR machine and replaces it
>>> in the KVMPPC_H_UPDATE_DT (new private hypercall) handler.
>>>
>>> This adds an @update_dt_enabled machine property to allow backward
>>> migration.
>>>
>>> SLOF already has a hypercall since
>>> https://github.com/aik/SLOF/commit/e6fc84652c9c0073f9183
>>>
>>> This makes use of the new fdt_check_full() helper. In order to allow
>>> the configure script to pick the correct DTC version, this adjusts
>>> the DTC presense test.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>>
>> Applied, thanks.
> 
> And now, unapplied.
> 
> I don't know quite how, but somehow this patch is causing aarch64
> tests to SEGV.


/home/aik/p/qemu/configure --target-list=aarch64-softmmu
--source-path=/home/aik/p/qemu/ --disable-git-update --with-git=false
   --enable-trace-backend=log

and

make -C /home/aik/pbuild/qemu-localhost-aarch64-rel/ -j24 check

did not produce segv. I am running this all on a power8 box + ubuntu
1804, what is your config?



-- 
Alexey