Re: [Qemu-devel] [PATCH v7 10/23] qapi: Define new QMP message for pvrdma

[Yuval Shaia]

On Mon, Dec 17, 2018 at 10:00:32AM -0600, Eric Blake wrote:
> On 12/17/18 2:10 AM, Yuval Shaia wrote:
> > pvrdma requires that the same GID attached to it will be attached to the
> > backend device in the host.
> > 
> > A new QMP messages is defined so pvrdma device can broadcast any change
> > made to its GID table. This event is captured by libvirt which in  turn
> > will update the GID table in the backend device.
> > 
> > Depend on: "qapi: Reduce Makefile boilerplate"
> 
> This line fits better...
> 
> > 
> > Signed-off-by: Yuval Shaia <address@hidden>
> > Reviewed-by: Marcel Apfelbaum <address@hidden>
> > Acked-by: Markus Armbruster <address@hidden>
> > ---
> 
> ...here, where it is useful to reviewers but stripped by 'git am'. Remember,
> the commit message that lives in qemu.git is what people will care about a
> year from now, and if the dependency was correctly satisfied (which is now
> guaranteed, as commit bf582c34 has now landed), then the fact that this
> commit is in git means its dependencies have already been satisfied. A year
> from now, no one will care about what the dependencies were in developing
> the patch.

Thanks, will delete.

> 
> 
> > +##
> > +# @RDMA_GID_STATUS_CHANGED:
> > +#
> > +# Emitted when guest driver adds/deletes GID to/from device
> > +#
> > +# @netdev: RoCE Network Device name - char *
> > +#
> > +# @gid-status: Add or delete indication - bool
> 
> Listing the type of each member here is redundant...
> 
> > +{ 'event': 'RDMA_GID_STATUS_CHANGED',
> > +  'data': { 'netdev'        : 'str',
> > +            'gid-status'    : 'bool',
> 
> because the docs generator should already be using the type from here to do
> that on your behalf.

Thanks.

> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org