[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 1/8] hw: acpi: The RSDP build API can return void
From: |
Samuel Ortiz |
Subject: |
[Qemu-devel] [PATCH v4 1/8] hw: acpi: The RSDP build API can return void |
Date: |
Mon, 17 Dec 2018 11:48:31 +0100 |
For both x86 and ARM architectures, the internal RSDP build API can
return void as the current return value is unused.
Signed-off-by: Samuel Ortiz <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Andrew Jones <address@hidden>
---
hw/arm/virt-acpi-build.c | 4 +---
hw/i386/acpi-build.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 5785fb697c..fcaa350892 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -367,7 +367,7 @@ static void acpi_dsdt_add_power_button(Aml *scope)
}
/* RSDP */
-static GArray *
+static void
build_rsdp(GArray *rsdp_table, BIOSLinker *linker, unsigned xsdt_tbl_offset)
{
AcpiRsdpDescriptor *rsdp = acpi_data_push(rsdp_table, sizeof *rsdp);
@@ -392,8 +392,6 @@ build_rsdp(GArray *rsdp_table, BIOSLinker *linker, unsigned
xsdt_tbl_offset)
bios_linker_loader_add_checksum(linker, ACPI_BUILD_RSDP_FILE,
(char *)rsdp - rsdp_table->data, sizeof *rsdp,
(char *)&rsdp->checksum - rsdp_table->data);
-
- return rsdp_table;
}
static void
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 236a20eaa8..35f17d0d91 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -2547,7 +2547,7 @@ build_amd_iommu(GArray *table_data, BIOSLinker *linker)
"IVRS", table_data->len - iommu_start, 1, NULL, NULL);
}
-static GArray *
+static void
build_rsdp(GArray *rsdp_table, BIOSLinker *linker, unsigned rsdt_tbl_offset)
{
AcpiRsdpDescriptor *rsdp = acpi_data_push(rsdp_table, sizeof *rsdp);
@@ -2569,8 +2569,6 @@ build_rsdp(GArray *rsdp_table, BIOSLinker *linker,
unsigned rsdt_tbl_offset)
bios_linker_loader_add_checksum(linker, ACPI_BUILD_RSDP_FILE,
(char *)rsdp - rsdp_table->data, sizeof *rsdp,
(char *)&rsdp->checksum - rsdp_table->data);
-
- return rsdp_table;
}
typedef
--
2.19.2
- Re: [Qemu-devel] [PATCH v4 7/8] hw: acpi: Export and share the ARM RSDP build, (continued)
Re: [Qemu-devel] [PATCH v4 7/8] hw: acpi: Export and share the ARM RSDP build, Samuel Ortiz, 2018/12/17
[Qemu-devel] [PATCH v5 7/8] hw: acpi: Export and share the ARM RSDP build, Samuel Ortiz, 2018/12/17
[Qemu-devel] [PATCH v4 4/8] hw: arm: Carry RSDP specific data through AcpiRsdpData, Samuel Ortiz, 2018/12/17
[Qemu-devel] [PATCH v4 3/8] hw: i386: Use correct RSDT length for checksum, Samuel Ortiz, 2018/12/17
[Qemu-devel] [PATCH v4 1/8] hw: acpi: The RSDP build API can return void,
Samuel Ortiz <=
[Qemu-devel] [PATCH v4 2/8] hw: arm: acpi: Fix incorrect checksums in RSDP, Samuel Ortiz, 2018/12/17
Re: [Qemu-devel] [PATCH v4 0/8] hw: acpi: RSDP fixes and refactoring, Michael S. Tsirkin, 2018/12/17